third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2073563002: Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2073563002: Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix flipped blocks for tables. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 5255bb300d90dc11ced663264acbfcd9eec11f6b..183a6638647cdc8bdb7c14d3886d193c595cc845 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -2299,7 +2299,7 @@ IntRect CompositedLayerMapping::recomputeInterestRect(const GraphicsLayer* graph

FloatRect graphicsLayerBoundsInObjectSpace(graphicsLayerBounds);

graphicsLayerBoundsInObjectSpace.move(offsetFromAnchorLayoutObject);

// The object space means including writing mode flip.

- if (anchorLayoutObject->isBox())

+ if (anchorLayoutObject->isBox() && !anchorLayoutObject->isLayoutView())

chrishtr 2016/07/08 19:54:51 Why this change?

wkorman 2016/07/08 23:55:50 Good point, it looks like perhaps we can as you su

toLayoutBox(anchorLayoutObject)->flipForWritingMode(graphicsLayerBoundsInObjectSpace);

// Now map the bounds to its visible content rect in screen space, including applying clips along the way.

« no previous file with comments | « third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp ('k') | no next file » | no next file with comments »