Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2073563002: Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync to head. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 compositor()->fullyInvalidatePaint(); 441 compositor()->fullyInvalidatePaint();
442 } 442 }
443 443
444 bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance stor, LayoutRect& rect, VisualRectFlags visualRectFlags) const 444 bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance stor, LayoutRect& rect, VisualRectFlags visualRectFlags) const
445 { 445 {
446 return mapToVisualRectInAncestorSpace(ancestor, rect, 0, visualRectFlags); 446 return mapToVisualRectInAncestorSpace(ancestor, rect, 0, visualRectFlags);
447 } 447 }
448 448
449 bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance stor, LayoutRect& rect, MapCoordinatesFlags mode, VisualRectFlags visualRectFlag s) const 449 bool LayoutView::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ance stor, LayoutRect& rect, MapCoordinatesFlags mode, VisualRectFlags visualRectFlag s) const
450 { 450 {
451 // Convert the rect into the physical coordinates space of this LayoutView.
452 flipForWritingMode(rect);
453
454 if (mode & IsFixed) 451 if (mode & IsFixed)
455 adjustOffsetForFixedPosition(rect); 452 adjustOffsetForFixedPosition(rect);
456 453
457 // Apply our transform if we have one (because of full page zooming). 454 // Apply our transform if we have one (because of full page zooming).
458 if (!ancestor && layer() && layer()->transform()) 455 if (!ancestor && layer() && layer()->transform())
459 rect = layer()->transform()->mapRect(rect); 456 rect = layer()->transform()->mapRect(rect);
460 457
461 ASSERT(ancestor); 458 ASSERT(ancestor);
462 if (ancestor == this) 459 if (ancestor == this)
463 return true; 460 return true;
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
1003 // of this override. All frame scrolling should be handled by 1000 // of this override. All frame scrolling should be handled by
1004 // ViewportScrollCallback. 1001 // ViewportScrollCallback.
1005 1002
1006 if (!frameView()) 1003 if (!frameView())
1007 return ScrollResult(false, false, delta.width(), delta.height()); 1004 return ScrollResult(false, false, delta.width(), delta.height());
1008 1005
1009 return frameView()->getScrollableArea()->userScroll(granularity, delta); 1006 return frameView()->getScrollableArea()->userScroll(granularity, delta);
1010 } 1007 }
1011 1008
1012 } // namespace blink 1009 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698