Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly.

third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/PaintInvalidationState.h"
 #include "core/paint/PaintLayer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 153 matching lines @@
         "</div>");
 
     LayoutBlock* target = toLayoutBlock(getLayoutObjectByElementId("target"));
     LayoutRect overflowRect = target->localOverflowRectForPaintInvalidation();
     // -40 = -box_shadow_offset_x(40) (with target's top-right corner as the origin)
     // 140 = width(100) + box_shadow_offset_x(40)
     // 70 = height(50) + box_shadow_offset_y(20)
     EXPECT_EQ(LayoutRect(-40, 0, 140, 70), overflowRect);
 
     LayoutRect rect = overflowRect;
+    // TODO(wkorman): The calls to flipForWritingMode() here and in other test
+    // cases below are necessary because mapToVisualRectInAncestorSpace()
+    // currently expects the input rect to be in "physical coordinates with

[chrishtr, 2016/07/11 22:35:11]

It's the other way around. They are expected to be in physical coordinate space,
*without* flipped block-flow direction.

[wkorman, 2016/07/11 22:46:17]

Ah, yes, I wrote as if documenting slowMapToVisualRectInAncestorSpace. Fixed.

+    // flipped block-flow direction" (see LayoutBoxModelObject.h). If we rework
+    // to take them as physical, we can remove these flips.
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(target, rect));
     // This rect is in physical coordinates of target.
     EXPECT_EQ(LayoutRect(0, 0, 140, 70), rect);
 
     rect = overflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(&layoutView(), rect));
     EXPECT_EQ(LayoutRect(222, 111, 140, 70), rect);
     checkPaintInvalidationStateRectMapping(rect, overflowRect, *target, layoutView(), layoutView());
 }
 
 TEST_F(VisualRectMappingTest, ContainerFlippedWritingMode)
 {
     setBodyInnerHTML(
         "<div id='container' style='writing-mode: vertical-rl; position: absolute; top: 111px; left: 222px'>"
         "    <div id='target' style='box-shadow: 40px 20px black; width: 100px; height: 90px'></div>"
         "    <div style='width: 100px; height: 100px'></div>"
         "</div>");
 
     LayoutBlock* target = toLayoutBlock(getLayoutObjectByElementId("target"));
     LayoutRect targetOverflowRect = target->localOverflowRectForPaintInvalidation();
     // -40 = -box_shadow_offset_x(40) (with target's top-right corner as the origin)
     // 140 = width(100) + box_shadow_offset_x(40)
     // 110 = height(90) + box_shadow_offset_y(20)
     EXPECT_EQ(LayoutRect(-40, 0, 140, 110), targetOverflowRect);
 
     LayoutRect rect = targetOverflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(target, rect));
     // This rect is in physical coordinates of target.
     EXPECT_EQ(LayoutRect(0, 0, 140, 110), rect);
 
     LayoutBlock* container = toLayoutBlock(getLayoutObjectByElementId("container"));
     rect = targetOverflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(container, rect));
     // 100 is the physical x location of target in container.
     EXPECT_EQ(LayoutRect(100, 0, 140, 110), rect);
     rect = targetOverflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(&layoutView(), rect));
     EXPECT_EQ(LayoutRect(322, 111, 140, 110), rect);
     checkPaintInvalidationStateRectMapping(rect, targetOverflowRect, *target, layoutView(), layoutView());
 
     LayoutRect containerOverflowRect = container->localOverflowRectForPaintInvalidation();
     EXPECT_EQ(LayoutRect(0, 0, 200, 100), containerOverflowRect);
     rect = containerOverflowRect;
+    container->flipForWritingMode(rect);
     EXPECT_TRUE(container->mapToVisualRectInAncestorSpace(container, rect));
     EXPECT_EQ(LayoutRect(0, 0, 200, 100), rect);
     rect = containerOverflowRect;
+    container->flipForWritingMode(rect);
     EXPECT_TRUE(container->mapToVisualRectInAncestorSpace(&layoutView(), rect));
     EXPECT_EQ(LayoutRect(222, 111, 200, 100), rect);
     checkPaintInvalidationStateRectMapping(rect, containerOverflowRect, *container, layoutView(), layoutView());
 }
 
 TEST_F(VisualRectMappingTest, ContainerOverflowScroll)
 {
     setBodyInnerHTML(
         "<div id='container' style='position: absolute; top: 111px; left: 222px;"
         "    border: 10px solid red; overflow: scroll; width: 50px; height: 80px;'>"
@@ skipping 66 matching lines @@
     document().view()->updateAllLifecyclePhases();
 
     LayoutBlock* target = toLayoutBlock(getLayoutObjectByElementId("target"));
     LayoutRect targetOverflowRect = target->localOverflowRectForPaintInvalidation();
     // -40 = -box_shadow_offset_x(40) (with target's top-right corner as the origin)
     // 140 = width(100) + box_shadow_offset_x(40)
     // 110 = height(90) + box_shadow_offset_y(20)
     EXPECT_EQ(LayoutRect(-40, 0, 140, 110), targetOverflowRect);
 
     LayoutRect rect = targetOverflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(target, rect));
     // This rect is in physical coordinates of target.
     EXPECT_EQ(LayoutRect(0, 0, 140, 110), rect);
 
     rect = targetOverflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(container, rect));
     // -2 = target_physical_x(100) + container_border_left(40) - scroll_left(142)
     // 3 = target_y(0) + container_border_top(10) - scroll_top(7)
     // Rect is clipped by container's overflow clip because of overflow:scroll.
     EXPECT_EQ(LayoutRect(-2, 3, 140, 110), rect);
 
     rect = targetOverflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(&layoutView(), rect));
     // (-2, 3, 140, 100) is first clipped by container's overflow clip, to (40, 10, 50, 80),
     // then is added by container's offset in LayoutView (111, 222).
     // TODO(crbug.com/600039): rect.x() should be 262 (left + border-left), but is offset
     // by extra horizontal border-widths because of layout error.
     EXPECT_EQ(LayoutRect(322, 121, 50, 80), rect);
     checkPaintInvalidationStateRectMapping(rect, targetOverflowRect, *target, layoutView(), layoutView());
 
     LayoutRect containerOverflowRect = container->localOverflowRectForPaintInvalidation();
     // Because container has overflow clip, its visual overflow doesn't include overflow from children.
     // 110 = width(50) + border_left_width(40) + border_right_width(20)
     // 120 = height(80) + border_top_width(10) + border_bottom_width(30)
     EXPECT_EQ(LayoutRect(0, 0, 110, 120), containerOverflowRect);
 
     rect = containerOverflowRect;
+    container->flipForWritingMode(rect);
     EXPECT_TRUE(container->mapToVisualRectInAncestorSpace(container, rect));
     EXPECT_EQ(LayoutRect(0, 0, 110, 120), rect);
 
     rect = containerOverflowRect;
+    container->flipForWritingMode(rect);
     EXPECT_TRUE(container->mapToVisualRectInAncestorSpace(&layoutView(), rect));
     // TODO(crbug.com/600039): rect.x() should be 222 (left), but is offset by extra horizontal
     // border-widths because of layout error.
     EXPECT_EQ(LayoutRect(282, 111, 110, 120), rect);
     checkPaintInvalidationStateRectMapping(rect, containerOverflowRect, *container, layoutView(), layoutView());
 }
 
 TEST_F(VisualRectMappingTest, ContainerOverflowHidden)
 {
     setBodyInnerHTML(
@@ skipping 44 matching lines @@
     document().view()->updateAllLifecyclePhases();
 
     LayoutBlock* target = toLayoutBlock(getLayoutObjectByElementId("target"));
     LayoutRect targetOverflowRect = target->localOverflowRectForPaintInvalidation();
     // -40 = -box_shadow_offset_x(40) (with target's top-right corner as the origin)
     // 140 = width(100) + box_shadow_offset_x(40)
     // 110 = height(90) + box_shadow_offset_y(20)
     EXPECT_EQ(LayoutRect(-40, 0, 140, 110), targetOverflowRect);
 
     LayoutRect rect = targetOverflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(target, rect));
     // This rect is in physical coordinates of target.
     EXPECT_EQ(LayoutRect(0, 0, 140, 110), rect);
 
     rect = targetOverflowRect;
+    target->flipForWritingMode(rect);
     EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(container, rect));
     // 58 = target_physical_x(100) + container_border_left(40) - scroll_left(58)
     // The other sides of the rect are clipped by container's overflow clip.
     EXPECT_EQ(LayoutRect(58, 10, 32, 80), rect);
 }
 
 TEST_F(VisualRectMappingTest, ContainerAndTargetDifferentFlippedWritingMode)
 {
     setBodyInnerHTML(
         "<div id='container' style='writing-mode: vertical-rl; position: absolute; top: 111px; left: 222px;"
@@ skipping 97 matching lines @@
     LayoutRect absoluteOverflowRect = absolute->localOverflowRectForPaintInvalidation();
     EXPECT_EQ(LayoutRect(0, 0, 50, 50), absoluteOverflowRect);
     LayoutRect rect = absoluteOverflowRect;
     EXPECT_TRUE(absolute->mapToVisualRectInAncestorSpace(stackingContext, rect));
     // -172 = top(50) - y_offset_of_stacking_context(222)
     EXPECT_EQ(LayoutRect(50, -172, 50, 50), rect);
     checkPaintInvalidationStateRectMapping(rect, absoluteOverflowRect, *absolute, layoutView(), *stackingContext);
 }
 
 } // namespace blink