Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2073563002: Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't need to flip in CLM. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
868 return FloatPoint(m_frameRect.width() - position.x(), position.y()); 868 return FloatPoint(m_frameRect.width() - position.x(), position.y());
869 } 869 }
870 void flipForWritingMode(FloatRect& rect) const 870 void flipForWritingMode(FloatRect& rect) const
871 { 871 {
872 if (!UNLIKELY(hasFlippedBlocksWritingMode())) 872 if (!UNLIKELY(hasFlippedBlocksWritingMode()))
873 return; 873 return;
874 rect.setX(m_frameRect.width() - rect.maxX()); 874 rect.setX(m_frameRect.width() - rect.maxX());
875 } 875 }
876 // These represent your location relative to your container as a physical of fset. 876 // These represent your location relative to your container as a physical of fset.
877 // In layout related methods you almost always want the logical location (e. g. x() and y()). 877 // In layout related methods you almost always want the logical location (e. g. x() and y()).
878 LayoutPoint topLeftLocation() const; 878 LayoutPoint topLeftLocation(const LayoutBox* container = nullptr) const;
chrishtr 2016/07/09 00:15:57 Add a comment saying that passing |container| caus
wkorman 2016/07/09 01:16:08 Done.
879 LayoutSize topLeftLocationOffset() const { return toLayoutSize(topLeftLocati on()); } 879 LayoutSize topLeftLocationOffset() const { return toLayoutSize(topLeftLocati on()); }
880 880
881 LayoutRect logicalVisualOverflowRectForPropagation(const ComputedStyle&) con st; 881 LayoutRect logicalVisualOverflowRectForPropagation(const ComputedStyle&) con st;
882 LayoutRect visualOverflowRectForPropagation(const ComputedStyle&) const; 882 LayoutRect visualOverflowRectForPropagation(const ComputedStyle&) const;
883 LayoutRect logicalLayoutOverflowRectForPropagation(const ComputedStyle&) con st; 883 LayoutRect logicalLayoutOverflowRectForPropagation(const ComputedStyle&) con st;
884 LayoutRect layoutOverflowRectForPropagation(const ComputedStyle&) const; 884 LayoutRect layoutOverflowRectForPropagation(const ComputedStyle&) const;
885 885
886 bool hasOverflowModel() const { return m_overflow.get(); } 886 bool hasOverflowModel() const { return m_overflow.get(); }
887 bool hasSelfVisualOverflow() const { return m_overflow && !borderBoxRect().c ontains(m_overflow->selfVisualOverflowRect()); } 887 bool hasSelfVisualOverflow() const { return m_overflow && !borderBoxRect().c ontains(m_overflow->selfVisualOverflowRect()); }
888 bool hasVisualOverflow() const { return m_overflow && !borderBoxRect().conta ins(visualOverflowRect()); } 888 bool hasVisualOverflow() const { return m_overflow && !borderBoxRect().conta ins(visualOverflowRect()); }
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
1230 || breakValue == BreakLeft 1230 || breakValue == BreakLeft
1231 || breakValue == BreakPage 1231 || breakValue == BreakPage
1232 || breakValue == BreakRecto 1232 || breakValue == BreakRecto
1233 || breakValue == BreakRight 1233 || breakValue == BreakRight
1234 || breakValue == BreakVerso; 1234 || breakValue == BreakVerso;
1235 } 1235 }
1236 1236
1237 } // namespace blink 1237 } // namespace blink
1238 1238
1239 #endif // LayoutBox_h 1239 #endif // LayoutBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698