Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2073553003: Fix presubmit checkout test after git 2.9.0 (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix presubmit checkout test after git 2.9.0 Quoting https://github.com/blog/2188-git-2-9-has-been-released """Rename detection is now enabled by default for diffs..." which broke this test. R=tandrii@chromium.org, iannucci@chromium.org BUG=619959 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f3c688bf2ccbd54a302f69846b97e51c3e2fcc82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/checkout_test.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
scottmg
4 years, 6 months ago (2016-06-16 00:10:24 UTC) #2
iannucci
LGTM, --no-renames exists all the way back in 2.7
4 years, 6 months ago (2016-06-16 00:13:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073553003/1
4 years, 6 months ago (2016-06-16 00:13:29 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 00:16:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f3c688bf2ccbd5...

Powered by Google App Engine
This is Rietveld 408576698