Settings People Revamp: Add Manage Synced Data row to Sync Page.

Settings People Revamp: Add Manage Synced Data row to Sync Page.

Screenshot showing change: http://imgur.com/6G7vBm2

BUG=617186, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f7fe4c39b2d571dc313ecd4bf57033c7783c6b7a
Cr-Commit-Position: refs/heads/master@{#400056}

[tommycli, 2016-06-15 21:38:18]

Description was changed from

==========
Settings People Revamp: Add Manage Synced Data row to Sync Page.

Screenshot showing change: http://imgur.com/6G7vBm2

BUG=617186, 563721
==========

to

==========
Settings People Revamp: Add Manage Synced Data row to Sync Page.

Screenshot showing change: http://imgur.com/6G7vBm2

BUG=617186, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-06-15 21:38:51]

tommycli@chromium.org changed reviewers:
+ hcarmona@chromium.org

[tommycli, 2016-06-15 21:38:51]

hcarmona: PTAL XS sized review. Thanks!

[hcarmona, 2016-06-15 22:40:51]

LGTM with a nit.

https://codereview.chromium.org/2073543002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2073543002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1258: <message
name="IDS_SETTINGS_MANAGE_SYNCED_DATA_TITLE" desc="Title for the row to manage
Chrome Sync data via Google Dashboard.">
'row' might not make sense to a translator without further context.

Maybe 'link' or something else to communicate to the translator that
clicking this will take the user to the dashboard?

[tommycli, 2016-06-15 22:57:41]

thanks!

https://codereview.chromium.org/2073543002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2073543002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1258: <message
name="IDS_SETTINGS_MANAGE_SYNCED_DATA_TITLE" desc="Title for the row to manage
Chrome Sync data via Google Dashboard.">
On 2016/06/15 22:40:51, Hector Carmona wrote:
> 'row' might not make sense to a translator without further context.
> 
> Maybe 'link' or something else to communicate to the translator that
> clicking this will take the user to the dashboard?

Done.

[tommycli, 2016-06-15 23:09:55]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-06-15 23:09:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
hcarmona@chromium.org
Link to the patchset: https://codereview.chromium.org/2073543002/#ps20001
(title: "fix description")

[commit-bot: I haz the power, 2016-06-15 23:10:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073543002/20001

[tommycli, 2016-06-15 23:30:14]

hcarmona: thank you for the good (and also fast) review

[commit-bot: I haz the power, 2016-06-16 00:18:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-16 00:18:36]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 00:21:38]

Description was changed from

==========
Settings People Revamp: Add Manage Synced Data row to Sync Page.

Screenshot showing change: http://imgur.com/6G7vBm2

BUG=617186, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Add Manage Synced Data row to Sync Page.

Screenshot showing change: http://imgur.com/6G7vBm2

BUG=617186, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f7fe4c39b2d571dc313ecd4bf57033c7783c6b7a
Cr-Commit-Position: refs/heads/master@{#400056}
==========

[commit-bot: I haz the power, 2016-06-16 00:21:39]

Patchset 2 (id:??) landed as
https://crrev.com/f7fe4c39b2d571dc313ecd4bf57033c7783c6b7a
Cr-Commit-Position: refs/heads/master@{#400056}