Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2073413002: Remove RenderFrameImpl::is_detaching_, since it appears no longer needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 1057 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 // frame tree at the time the pending navigation commits. 1068 // frame tree at the time the pending navigation commits.
1069 // Frames added by the parent document are created from the renderer process 1069 // Frames added by the parent document are created from the renderer process
1070 // and are immediately inserted in the frame tree. 1070 // and are immediately inserted in the frame tree.
1071 // TODO(dcheng): Remove this once we have FrameTreeHandle and can use the 1071 // TODO(dcheng): Remove this once we have FrameTreeHandle and can use the
1072 // Blink Web* layer to check for provisional frames. 1072 // Blink Web* layer to check for provisional frames.
1073 bool in_frame_tree_; 1073 bool in_frame_tree_;
1074 1074
1075 base::WeakPtr<RenderViewImpl> render_view_; 1075 base::WeakPtr<RenderViewImpl> render_view_;
1076 int routing_id_; 1076 int routing_id_;
1077 1077
1078 bool is_detaching_;
1079
1080 // If this frame was created to replace a proxy, this will store the routing 1078 // If this frame was created to replace a proxy, this will store the routing
1081 // id of the proxy to replace at commit-time, at which time it will be 1079 // id of the proxy to replace at commit-time, at which time it will be
1082 // cleared. 1080 // cleared.
1083 // TODO(creis): Remove this after switching to PlzNavigate. 1081 // TODO(creis): Remove this after switching to PlzNavigate.
1084 int proxy_routing_id_; 1082 int proxy_routing_id_;
1085 1083
1086 // Non-null when the RenderFrame is a local root for compositing, input, 1084 // Non-null when the RenderFrame is a local root for compositing, input,
1087 // layout, etc. A local frame is also a local root iff it does not have a 1085 // layout, etc. A local frame is also a local root iff it does not have a
1088 // parent that is a local frame. 1086 // parent that is a local frame.
1089 scoped_refptr<RenderWidget> render_widget_; 1087 scoped_refptr<RenderWidget> render_widget_;
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
1287 mojom::FrameHostPtr frame_host_; 1285 mojom::FrameHostPtr frame_host_;
1288 1286
1289 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1287 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1290 1288
1291 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1289 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1292 }; 1290 };
1293 1291
1294 } // namespace content 1292 } // namespace content
1295 1293
1296 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1294 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698