Remove RenderFrameImpl::is_detaching_, since it appears no longer needed.

Remove RenderFrameImpl::is_detaching_, since it appears no longer needed.

ajwong@ added this in r219965 when making RFHs routable, without an
explanation at the time.
https://codereview.chromium.org/22876014/diff/76001/content/renderer/render_frame_impl.cc

ajwong@ later added a comment in r234992 about how it was necessary
to prevent observers from sending IPC messages after detach:
https://codereview.chromium.org/67313010/diff/160001/content/renderer/render_frame_impl.cc

nasko@ preserved this comment in r244023 when switching us over to
always have subframe RFHs:
https://codereview.chromium.org/117603002/diff/960001/content/renderer/render_frame_impl.cc

However, gcasto removed the observer behavior in r320838.  Since
that CL, observers have been able to send IPCs during detach and
(apparently) almost nothing is disabled by is_detaching_:
https://codereview.chromium.org/1014703003/diff/20001/content/renderer/render_frame_impl.cc

As a result, this appears to be mostly dead code at this point,
for over a year.  Since I'd like to add more IPCs after detach,
I'm removing this restriction.

BUG=609963
TEST=Existing tests still pass.

Committed: https://crrev.com/8aa4ed83d329e038980afa0fd10d880415b853a9
Cr-Commit-Position: refs/heads/master@{#400829}

[Charlie Reis, 2016-06-20 16:58:01]

Description was changed from

==========
Remove RenderFrameImpl::is_detaching_, since it is mostly dead code.

BUG=
TEST=
==========

to

==========
Remove RenderFrameImpl::is_detaching_, since it appears no longer needed.

ajwong@ added this in r219965 when making RFHs routable, without an
explanation at the time.
https://codereview.chromium.org/22876014/diff/76001/content/renderer/render_f...

ajwong@ later added a comment in r234992 about how it was necessary
to prevent observers from sending IPC messages after detach:
https://codereview.chromium.org/67313010/diff/160001/content/renderer/render_...

nasko@ preserved this comment in r244023 when switching us over to
always have subframe RFHs:
https://codereview.chromium.org/117603002/diff/960001/content/renderer/render...

However, gcasto removed the observer behavior in r320838.  Since
that CL, observers have been able to send IPCs during detach and
(apparently) almost nothing is disabled by is_detaching_:
https://codereview.chromium.org/1014703003/diff/20001/content/renderer/render...

As a result, this appears to be mostly dead code at this point,
for over a year.  Since I'd like to add more IPCs after detach,
I'm removing this restriction.

BUG=609963
TEST=Existing tests still pass.
==========

[Charlie Reis, 2016-06-20 16:58:01]

creis@chromium.org changed reviewers:
+ alexmos@chromium.org

[Charlie Reis, 2016-06-20 17:00:39]

Alex, can you take a look to see if this seems sane?  As best I can tell from
the source archaeology, it seems like the original intention for disabling IPCs
during detach no longer applies.  Removing the restriction will help with my
"pending delete FTN" work, since I'd like to send things like an UpdateState and
an ACK from the RenderFrameImpl destructor.

CC'ing Nasko, since he's probably aware of a lot of this but he's still OOO.

[Charlie Reis, 2016-06-20 22:14:24]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 22:14:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073413002/1

[alexmos, 2016-06-20 23:05:06]

On 2016/06/20 17:00:39, Charlie Reis wrote:
> Alex, can you take a look to see if this seems sane?  As best I can tell from
> the source archaeology, it seems like the original intention for disabling
IPCs
> during detach no longer applies.  Removing the restriction will help with my
> "pending delete FTN" work, since I'd like to send things like an UpdateState
and
> an ACK from the RenderFrameImpl destructor.
> 
> CC'ing Nasko, since he's probably aware of a lot of this but he's still OOO.

LGTM.  Thanks for the detailed archaeology analysis, that was very helpful.  It
seems that the is_detaching_ check might have been added to mirror the closing_
check in RenderWidget::Send, judging from this comment by ajwong:
https://codereview.chromium.org/22876014/diff/29001/content/renderer/render_f....
 That latter check is still there, though I couldn't find out the reason for
adding it; it traced back to the initial commit:
https://chromium.googlesource.com/chromium/src/+blame/08c5fe5d62ec33cd7215bcd...

I agree that this looks safe.  It seems that after is_detaching_ is set to true,
the only non-trivial call left is render_widget_->CloseForFrame(), but tracing
that, I didn't see any place that might try to send IPCs through the same frame.
 The try bots also seem happy, so let's give this a try. :)

[Charlie Reis, 2016-06-20 23:09:13]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2016-06-20 23:09:27]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-06-20 23:09:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073413002/1

[commit-bot: I haz the power, 2016-06-20 23:24:19]

Description was changed from

==========
Remove RenderFrameImpl::is_detaching_, since it appears no longer needed.

ajwong@ added this in r219965 when making RFHs routable, without an
explanation at the time.
https://codereview.chromium.org/22876014/diff/76001/content/renderer/render_f...

ajwong@ later added a comment in r234992 about how it was necessary
to prevent observers from sending IPC messages after detach:
https://codereview.chromium.org/67313010/diff/160001/content/renderer/render_...

nasko@ preserved this comment in r244023 when switching us over to
always have subframe RFHs:
https://codereview.chromium.org/117603002/diff/960001/content/renderer/render...

However, gcasto removed the observer behavior in r320838.  Since
that CL, observers have been able to send IPCs during detach and
(apparently) almost nothing is disabled by is_detaching_:
https://codereview.chromium.org/1014703003/diff/20001/content/renderer/render...

As a result, this appears to be mostly dead code at this point,
for over a year.  Since I'd like to add more IPCs after detach,
I'm removing this restriction.

BUG=609963
TEST=Existing tests still pass.
==========

to

==========
Remove RenderFrameImpl::is_detaching_, since it appears no longer needed.

ajwong@ added this in r219965 when making RFHs routable, without an
explanation at the time.
https://codereview.chromium.org/22876014/diff/76001/content/renderer/render_f...

ajwong@ later added a comment in r234992 about how it was necessary
to prevent observers from sending IPC messages after detach:
https://codereview.chromium.org/67313010/diff/160001/content/renderer/render_...

nasko@ preserved this comment in r244023 when switching us over to
always have subframe RFHs:
https://codereview.chromium.org/117603002/diff/960001/content/renderer/render...

However, gcasto removed the observer behavior in r320838.  Since
that CL, observers have been able to send IPCs during detach and
(apparently) almost nothing is disabled by is_detaching_:
https://codereview.chromium.org/1014703003/diff/20001/content/renderer/render...

As a result, this appears to be mostly dead code at this point,
for over a year.  Since I'd like to add more IPCs after detach,
I'm removing this restriction.

BUG=609963
TEST=Existing tests still pass.
==========

[commit-bot: I haz the power, 2016-06-20 23:24:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-20 23:26:36]

Description was changed from

==========
Remove RenderFrameImpl::is_detaching_, since it appears no longer needed.

ajwong@ added this in r219965 when making RFHs routable, without an
explanation at the time.
https://codereview.chromium.org/22876014/diff/76001/content/renderer/render_f...

ajwong@ later added a comment in r234992 about how it was necessary
to prevent observers from sending IPC messages after detach:
https://codereview.chromium.org/67313010/diff/160001/content/renderer/render_...

nasko@ preserved this comment in r244023 when switching us over to
always have subframe RFHs:
https://codereview.chromium.org/117603002/diff/960001/content/renderer/render...

However, gcasto removed the observer behavior in r320838.  Since
that CL, observers have been able to send IPCs during detach and
(apparently) almost nothing is disabled by is_detaching_:
https://codereview.chromium.org/1014703003/diff/20001/content/renderer/render...

As a result, this appears to be mostly dead code at this point,
for over a year.  Since I'd like to add more IPCs after detach,
I'm removing this restriction.

BUG=609963
TEST=Existing tests still pass.
==========

to

==========
Remove RenderFrameImpl::is_detaching_, since it appears no longer needed.

ajwong@ added this in r219965 when making RFHs routable, without an
explanation at the time.
https://codereview.chromium.org/22876014/diff/76001/content/renderer/render_f...

ajwong@ later added a comment in r234992 about how it was necessary
to prevent observers from sending IPC messages after detach:
https://codereview.chromium.org/67313010/diff/160001/content/renderer/render_...

nasko@ preserved this comment in r244023 when switching us over to
always have subframe RFHs:
https://codereview.chromium.org/117603002/diff/960001/content/renderer/render...

However, gcasto removed the observer behavior in r320838.  Since
that CL, observers have been able to send IPCs during detach and
(apparently) almost nothing is disabled by is_detaching_:
https://codereview.chromium.org/1014703003/diff/20001/content/renderer/render...

As a result, this appears to be mostly dead code at this point,
for over a year.  Since I'd like to add more IPCs after detach,
I'm removing this restriction.

BUG=609963
TEST=Existing tests still pass.

Committed: https://crrev.com/8aa4ed83d329e038980afa0fd10d880415b853a9
Cr-Commit-Position: refs/heads/master@{#400829}
==========

[commit-bot: I haz the power, 2016-06-20 23:26:37]

Patchset 1 (id:??) landed as
https://crrev.com/8aa4ed83d329e038980afa0fd10d880415b853a9
Cr-Commit-Position: refs/heads/master@{#400829}