Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2073403002: Re-land "Flip Linux bots on chromium.lkgr to GN." (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
Nico, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Flip Linux bots on chromium.lkgr to GN." This re-lands r398038 now that the bugs have been fixed. It also flips the CrOS ASAN builder. TBR=thakis@chromium.org, inferno@chromium.org BUG=605732 Committed: https://crrev.com/bba497d30d460399a070f121d3fb873e1bf13fd2 Cr-Commit-Position: refs/heads/master@{#400609}

Patch Set 1 #

Patch Set 2 : flip ChromiumOS ASAN Release as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M tools/mb/mb_config.pyl View 1 4 chunks +39 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-19 01:54:55 UTC) #1
Dirk Pranke
I believe the latest batch of bugs (ubsan, v8) have been fixed and so we ...
4 years, 6 months ago (2016-06-19 01:55:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073403002/20001
4 years, 6 months ago (2016-06-19 01:55:48 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-19 03:16:08 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bba497d30d460399a070f121d3fb873e1bf13fd2 Cr-Commit-Position: refs/heads/master@{#400609}
4 years, 6 months ago (2016-06-19 03:19:51 UTC) #7
Dirk Pranke
4 years, 6 months ago (2016-06-20 21:00:24 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2082793002/ by dpranke@chromium.org.

The reason for reverting is: Things are still broken (see crbug.com/621581)..

Powered by Google App Engine
This is Rietveld 408576698