Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: src/d8.cc

Issue 20734002: Implement correct OS and CC detection. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reverted changes to atomicops*.h Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler-intrinsics.h ('k') | src/d8-posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 1efe2ae0b407958fc4b2e0632e7597f4ae215fe2..f9dbbb9a9f731042f90d7f16f4f28e1744ef4304 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -68,7 +68,7 @@
#include "v8.h"
#endif // V8_SHARED
-#if !defined(_WIN32) && !defined(_WIN64)
+#if V8_OS_UNIX
#include <unistd.h> // NOLINT
#endif
@@ -868,7 +868,7 @@ Handle<ObjectTemplate> Shell::CreateGlobalTemplate(Isolate* isolate) {
RealmSharedGet, RealmSharedSet);
global_template->Set(String::New("Realm"), realm_template);
-#if !defined(V8_SHARED) && !defined(_WIN32) && !defined(_WIN64)
+#if !defined(V8_SHARED) && V8_OS_UNIX
Handle<ObjectTemplate> os_templ = ObjectTemplate::New();
AddOSMethods(os_templ);
global_template->Set(String::New("os"), os_templ);
@@ -1020,7 +1020,7 @@ void Shell::OnExit() {
static FILE* FOpen(const char* path, const char* mode) {
-#if defined(_MSC_VER) && (defined(_WIN32) || defined(_WIN64))
+#if V8_CC_MSVC
FILE* result;
if (fopen_s(&result, path, mode) == 0) {
return result;
« no previous file with comments | « src/compiler-intrinsics.h ('k') | src/d8-posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698