Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2073363002: Revert of [Telemetry] Allow users to select TBMv1 metrics to run alongside TBMv2 (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, petrcermak, telemetry-reviews_chromium.org, ulan
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Allow users to select TBMv1 metrics to run alongside TBMv2 (patchset #2 id:20001 of https://codereview.chromium.org/2073303002/ ) Reason for revert: Suspect making smoothness benchmarks failing, blocking catapult roll. See https://github.com/catapult-project/catapult/issues/2418 Original issue's description: > [Telemetry] Allow users to select TBMv1 metrics to run alongside TBMv2 > > This CL relaxes the restriction that users must choose either a list of TBMv1 > metrics, or a TBMv2 metric, to be run by a benchmark. It reconciles the legacy > functionality that selects all TBMv1 metrics by default in the following way: > > 1. If a TBMv2 metric is specified, any explicitly specified (using > SetLegacyTimelineBasedMetrics) v1 metrics will also be computed. > 2. If a TBMv2 metric is not specified, but TBMv1 metrics are specified, only > the selected TBMv1 metrics will be computed. > 3. If neither a TBMv2 metric nor any TBMv1 metrics are specified, all TBMv1 > metrics will be computed and no TBMv2 metric will be computed. > > BUG=chromium:621035 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/054fe195c7bcf92dc42d2567492eb1e04281c0db TBR=eakuefner@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:621035 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/713623b3921722ef8eadde8369283cd7abaf3e72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M telemetry/telemetry/web_perf/timeline_based_measurement.py View 3 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nednguyen
Created Revert of [Telemetry] Allow users to select TBMv1 metrics to run alongside TBMv2
4 years, 6 months ago (2016-06-18 01:10:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073363002/1
4 years, 6 months ago (2016-06-18 01:10:45 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 01:10:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698