Timeline addTraceProvider API

third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 49 matching lines @@
     // Create models.
     this._tracingModelBackingStorage = new WebInspector.TempFileBackingStorage("tracing");
     this._tracingModel = new WebInspector.TracingModel(this._tracingModelBackingStorage);
     this._model = new WebInspector.TimelineModel(WebInspector.TimelineUIUtils.visibleEventsFilter());
     this._frameModel = new WebInspector.TimelineFrameModel(event => WebInspector.TimelineUIUtils.eventStyle(event).category.name);
     this._irModel = new WebInspector.TimelineIRModel();
 
     if (Runtime.experiments.isEnabled("cpuThrottling"))
         this._cpuThrottlingManager = new WebInspector.CPUThrottlingManager();
 
+    // Create extension trace providers.
+    this._traceProvidersById = {};

[caseq, 2016/06/21 07:29:51]

We prefer using maps in the new code, i.e.

/**
  * @type {!Map<string, !WebInspector.TraceProvider>}
  *
this._traceProvidersById = new Map();

+    this._captureExtensionSettings = {};

[caseq, 2016/06/21 07:29:51]

ditto.

+    var extensionTraceProviders = WebInspector.extensionServer.traceProviders();
+    for (var i = 0; i < extensionTraceProviders.length; ++i) {
+        var provider = extensionTraceProviders[i];

[caseq, 2016/06/21 07:29:51]

nit: for (var provider of extensionTraceProviders) { ...

+        this.addTraceProvider(provider);
+        this._captureExtensionSettings[provider.id] = WebInspector.settings.createSetting(provider.categoryName, false);
+    }
+
     /** @type {!Array.<!WebInspector.TimelineModeView>} */
     this._currentViews = [];
 
     this._captureNetworkSetting = WebInspector.settings.createSetting("timelineCaptureNetwork", false);
     this._captureJSProfileSetting = WebInspector.settings.createSetting("timelineEnableJSSampling", true);
     this._captureMemorySetting = WebInspector.settings.createSetting("timelineCaptureMemory", false);
     this._captureLayersAndPicturesSetting = WebInspector.settings.createSetting("timelineCaptureLayersAndPictures", false);
     this._captureFilmStripSetting = WebInspector.settings.createSetting("timelineCaptureFilmStrip", false);
 
     this._panelToolbar = new WebInspector.Toolbar("", this.element);
@@ skipping 75 matching lines @@
     StopPending: Symbol("StopPending"),
     Loading: Symbol("Loading")
 }
 
 // Define row and header height, should be in sync with styles for timeline graphs.
 WebInspector.TimelinePanel.rowHeight = 18;
 WebInspector.TimelinePanel.headerHeight = 20;
 
 WebInspector.TimelinePanel.prototype = {
     /**
+     * @return {!Object.<string, !WebInspector.ExtensionTraceProvider>}
+     */
+    get traceProvidersById()

[caseq, 2016/06/21 07:29:51]

do you need to expose this? Also, we avoid getters in the new code, just use
functions.

+    {
+        return this._traceProvidersById;
+    },
+
+    addTraceProvider: function(provider)
+    {
+        this._traceProvidersById[provider.id] = provider;
+    },
+
+     /**
+     * @param {string} id
+     * @return {!WebInspector.ExtensionTraceProvider}
+     */
+    getTraceProvider: function(id)

[caseq, 2016/06/21 07:29:51]

not sure you need to expose any of these (also: please drop "get" prefixes on
getters and prefix with underscores for "private" methods)

+    {
+        return this.traceProvidersById[id];
+    },
+
+    /**
      * @override
      * @return {?WebInspector.SearchableView}
      */
     searchableView: function()
     {
         return this._searchableView;
     },
 
     wasShown: function()
     {
@@ skipping 208 matching lines @@
         if (!Runtime.experiments.isEnabled("timelineRecordingPerspectives") || perspectiveSetting.get() === WebInspector.TimelinePanel.Perspectives.Custom) {
             this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(
                 WebInspector.UIString("Network"), this._captureNetworkSetting, WebInspector.UIString("Show network requests information")));
             this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(
                 WebInspector.UIString("JS Profile"), this._captureJSProfileSetting, WebInspector.UIString("Capture JavaScript stacks with sampling profiler. (Has small performance overhead)")));
             this._panelToolbar.appendToolbarItem(screenshotCheckbox);
             this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(
                 WebInspector.UIString("Memory"), this._captureMemorySetting, WebInspector.UIString("Capture memory information on every timeline event.")));
             this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(
                 WebInspector.UIString("Paint"), this._captureLayersAndPicturesSetting, WebInspector.UIString("Capture graphics layer positions and rasterization draw calls. (Has large performance overhead)")));
+            for (var s in this._captureExtensionSettings) {

[caseq, 2016/06/21 07:29:51]

I guess you also want to handle TraceProviderAdded to handle the trace providers
added after timeline panel is instantiated.

+                this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(
+                    WebInspector.UIString(this._traceProvidersById[s].categoryName), this._captureExtensionSettings[s], WebInspector.UIString(this._traceProvidersById[s].categoryTooltip)));
+            }
+
         } else {
             this._panelToolbar.appendToolbarItem(screenshotCheckbox);
         }
 
         this._captureNetworkSetting.addChangeListener(this._onNetworkChanged, this);
         this._captureMemorySetting.addChangeListener(this._onModeChanged, this);
         this._captureFilmStripSetting.addChangeListener(this._onModeChanged, this);
 
         this._panelToolbar.appendSeparator();
         var garbageCollectButton = new WebInspector.ToolbarButton(WebInspector.UIString("Collect garbage"), "garbage-collect-toolbar-item");
@@ skipping 1634 matching lines @@
      * @override
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target)
     {
         this._targets.remove(target, true);
     },
 
     __proto__: WebInspector.Object.prototype
 }