Timeline addTraceProvider API

third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
         apiPrivate.panels = {};
     apiPrivate.panels.SearchAction = {
         CancelSearch: "cancelSearch",
         PerformSearch: "performSearch",
         NextSearchResult: "nextSearchResult",
         PreviousSearchResult: "previousSearchResult"
     };
 
     apiPrivate.Events = {
         AuditStarted: "audit-started-",
+        RecordingStarted: "recording-started-",

[caseq, 2016/06/21 07:29:51]

nit: "trace-recording-started-"

         ButtonClicked: "button-clicked-",
         PanelObjectSelected: "panel-objectSelected-",
         NetworkRequestFinished: "network-request-finished",
         OpenResource: "open-resource",
         PanelSearch: "panel-search-",
         ResourceAdded: "resource-added",
         ResourceContentCommitted: "resource-content-committed",
         ViewShown: "view-shown-",
         ViewHidden: "view-hidden-"
     };
 
     apiPrivate.Commands = {
         AddAuditCategory: "addAuditCategory",
         AddAuditResult: "addAuditResult",
         AddRequestHeaders: "addRequestHeaders",
+        AddTraceProvider: "addTraceProvider",
         ApplyStyleSheet: "applyStyleSheet",
         CreatePanel: "createPanel",
         CreateSidebarPane: "createSidebarPane",
         CreateToolbarButton: "createToolbarButton",
         EvaluateOnInspectedPage: "evaluateOnInspectedPage",
         ForwardKeyboardEvent: "_forwardKeyboardEvent",
         GetHAR: "getHAR",
         GetPageResources: "getPageResources",
         GetRequestContent: "getRequestContent",
         GetResourceContent: "getResourceContent",
@@ skipping 88 matching lines @@
              this._fire.apply(this, request.arguments);
     }
 }
 
 /**
  * @constructor
  */
 function InspectorExtensionAPI()
 {
     this.audits = new Audits();
+    this.timeline = new Timeline();
     this.inspectedWindow = new InspectedWindow();
     this.panels = new Panels();
     this.network = new Network();
     defineDeprecatedProperty(this, "webInspector", "resources", "network");
 }
 
 /**
  * @constructor
  */
 function Network()
@@ skipping 359 matching lines @@
             tooltip: tooltipText,
             disabled: !!disabled
         };
         extensionServer.sendRequest(request);
     }
 };
 
 /**
  * @constructor
  */
+function Timeline()
+{
+}
+
+Timeline.prototype = {
+    /**
+     * @param {string} categoryName
+     * @param {string} categoryTooltip
+     * @return {!TraceProvider}
+     */
+    addTraceProvider: function(categoryName, categoryTooltip)
+    {
+        var id = "extension-timeline-category-" + extensionServer.nextObjectId();
+        extensionServer.sendRequest({ command: commands.AddTraceProvider, id: id, categoryName: categoryName, categoryTooltip: categoryTooltip});
+        return new TraceProvider(id);
+    }
+}
+
+/**
+ * @constructor
+ */
+function TraceProvider(id)
+{
+    /**
+     * @this {EventSinkImpl}
+     */
+    function dispatchRecordingEvent(request)

[caseq, 2016/06/21 07:29:51]

Looks like you don't need the custom dispatch callback, just drop it and the
EventSink will do all the magic on its own.

+    {
+        this._fire();
+    }
+    this._id = id;

[caseq, 2016/06/21 07:29:51]

do you need this?

+    this.onRecordingStarted = new EventSink(events.RecordingStarted + id, dispatchRecordingEvent);
+}
+
+/**
+ * @constructor
+ */
 function Audits()
 {
 }
 
 Audits.prototype = {
     /**
      * @return {!AuditCategory}
      */
     addCategory: function(displayName, resultCount)
     {
@@ skipping 449 matching lines @@
 {
     return "(function(injectedScriptId){ " +
         "var extensionServer;" +
         defineCommonExtensionSymbols.toString() + ";" +
         injectedExtensionAPI.toString() + ";" +
         buildPlatformExtensionAPI(extensionInfo, inspectedTabId) + ";" +
         "platformExtensionAPI(injectedExtensionAPI(injectedScriptId));" +
         "return {};" +
         "})";
 }