Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2073323002: Change the value separator for stats default param. (Closed)

Created:
4 years, 6 months ago by gayane -on leave until 09-2017
Modified:
4 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, Alexei Svitkine (slow), gab, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the value separator for stats default param. Change the value separator from ":" to "=" as the first one is not valid for installer download URL. BUG=612825 Committed: https://crrev.com/5772c8dd4e59597759d6b000feca9cc99869bee9 Cr-Commit-Position: refs/heads/master@{#400568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/installer/util/channel_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/channel_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/channel_info_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
gayane -on leave until 09-2017
Please have a look.
4 years, 6 months ago (2016-06-17 23:02:29 UTC) #4
Lei Zhang
I defer grt@. + the rest of chrome/installer/OWNERS in case they want to chime in.
4 years, 6 months ago (2016-06-17 23:22:05 UTC) #6
grt (UTC plus 2)
Thanks Lei. It's too bad the dlpage requires this, but lgtm. I'm glad the change ...
4 years, 6 months ago (2016-06-17 23:27:16 UTC) #7
gayane -on leave until 09-2017
Thanks for the quick review
4 years, 6 months ago (2016-06-18 01:05:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073323002/1
4 years, 6 months ago (2016-06-18 01:44:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-18 01:48:28 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 01:50:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5772c8dd4e59597759d6b000feca9cc99869bee9
Cr-Commit-Position: refs/heads/master@{#400568}

Powered by Google App Engine
This is Rietveld 408576698