Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2073293002: Revert of JobController 1: Remove cross reference between Request, Job, and Impl (Closed)

Created:
4 years, 6 months ago by Zhongyi Shi
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of JobController 1: Remove cross reference between Request, Job, and Impl (patchset #23 id:660001 of https://codereview.chromium.org/1941083002/ ) Reason for revert: This CL is top 1 causing crash. Revert this patch and re-land once we fixed the bug. Original issue's description: > JobController 1: Remove cross reference between Request, Job, and Impl. > > BUG=605398 > > Committed: https://crrev.com/efbff200c26039dcd1ea0a4d585662629a8b9e69 > Cr-Commit-Position: refs/heads/master@{#400086} TBR=rch@chromium.org,rdsmith@chromium.org,tbansal@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605398 Committed: https://crrev.com/3c520078a25a61ccef467e00b3906fb8a98bcc1d Cr-Commit-Position: refs/heads/master@{#400525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+884 lines, -2048 lines) Patch
M net/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_basic_stream.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/http/http_stream_factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_stream_factory.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 5 chunks +35 lines, -23 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 5 chunks +262 lines, -72 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 11 chunks +20 lines, -161 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 26 chunks +161 lines, -89 lines 0 comments Download
D net/http/http_stream_factory_impl_job_controller.h View 1 chunk +0 lines, -234 lines 0 comments Download
D net/http/http_stream_factory_impl_job_controller.cc View 1 chunk +0 lines, -819 lines 0 comments Download
D net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 chunk +0 lines, -258 lines 0 comments Download
M net/http/http_stream_factory_impl_request.h View 5 chunks +56 lines, -44 lines 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 5 chunks +248 lines, -10 lines 0 comments Download
M net/http/http_stream_factory_impl_request_unittest.cc View 4 chunks +74 lines, -48 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 3 chunks +10 lines, -0 lines 0 comments Download
D net/http/http_stream_factory_test_util.h View 1 chunk +0 lines, -168 lines 0 comments Download
D net/http/http_stream_factory_test_util.cc View 1 chunk +0 lines, -112 lines 0 comments Download
M net/net.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M net/net.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Zhongyi Shi
Created Revert of JobController 1: Remove cross reference between Request, Job, and Impl
4 years, 6 months ago (2016-06-17 21:23:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073293002/1
4 years, 6 months ago (2016-06-17 21:24:22 UTC) #3
Ryan Hamilton
lgtm
4 years, 6 months ago (2016-06-17 21:26:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 22:25:10 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 22:26:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c520078a25a61ccef467e00b3906fb8a98bcc1d
Cr-Commit-Position: refs/heads/master@{#400525}

Powered by Google App Engine
This is Rietveld 408576698