Do not trigger Lo-Fi on main frame requests

Do not trigger Lo-Fi on main frame requests

BUG=619513
Committed: https://crrev.com/0fed1fbe1bc0ea5fa0a98795bd203f7a929ef2e9
Cr-Commit-Position: refs/heads/master@{#401460}

[tbansal1, 2016-06-17 20:38:44]

tbansal@chromium.org changed reviewers:
+ megjablon@chromium.org

[tbansal1, 2016-06-17 20:38:45]

ptal. thanks.

[megjablon, 2016-06-21 00:34:04]

https://codereview.chromium.org/2073233002/diff/1/components/data_reduction_p...
File components/data_reduction_proxy/content/browser/content_lofi_decider.cc
(right):

https://codereview.chromium.org/2073233002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/content/browser/content_lofi_decider.cc:86: //
to subrequests when preview mode is enabled.
Update this comment.

[tbansal1, 2016-06-22 18:07:55]

Patchset #3 (id:40001) has been deleted

[tbansal1, 2016-06-22 18:08:38]

megjablon: ptal. Thanks.

https://codereview.chromium.org/2073233002/diff/1/components/data_reduction_p...
File components/data_reduction_proxy/content/browser/content_lofi_decider.cc
(right):

https://codereview.chromium.org/2073233002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/content/browser/content_lofi_decider.cc:86: //
to subrequests when preview mode is enabled.
On 2016/06/21 00:34:03, megjablon wrote:
> Update this comment.

I removed the comment because it was incorrect. |header_value| is set in Line 63
above. So, even if there was nothing more was added to it, it may still be
non-empty.

[megjablon, 2016-06-22 20:56:29]

lgtm % comment

https://codereview.chromium.org/2073233002/diff/60001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_decider.cc
(right):

https://codereview.chromium.org/2073233002/diff/60001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_decider.cc:80: //
If previews are not enabled, add "q=low" for main frame requests.
If previews are not enabled, add "q=low" for requests that are not main frame
requests.

[tbansal1, 2016-06-22 21:41:03]

https://codereview.chromium.org/2073233002/diff/60001/components/data_reducti...
File components/data_reduction_proxy/content/browser/content_lofi_decider.cc
(right):

https://codereview.chromium.org/2073233002/diff/60001/components/data_reducti...
components/data_reduction_proxy/content/browser/content_lofi_decider.cc:80: //
If previews are not enabled, add "q=low" for main frame requests.
On 2016/06/22 20:56:29, megjablon wrote:
> If previews are not enabled, add "q=low" for requests that are not main frame
> requests.

Done.

[tbansal1, 2016-06-22 21:41:06]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-06-22 21:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
megjablon@chromium.org
Link to the patchset: https://codereview.chromium.org/2073233002/#ps80001
(title: "Fixed comment")

[commit-bot: I haz the power, 2016-06-22 21:42:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073233002/80001

[commit-bot: I haz the power, 2016-06-22 23:36:15]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-06-22 23:40:47]

Description was changed from

==========
Do not trigger Lo-Fi on main frame requests

BUG=619513
==========

to

==========
Do not trigger Lo-Fi on main frame requests

BUG=619513

Committed: https://crrev.com/0fed1fbe1bc0ea5fa0a98795bd203f7a929ef2e9
Cr-Commit-Position: refs/heads/master@{#401460}
==========

[commit-bot: I haz the power, 2016-06-22 23:40:48]

Patchset 4 (id:??) landed as
https://crrev.com/0fed1fbe1bc0ea5fa0a98795bd203f7a929ef2e9
Cr-Commit-Position: refs/heads/master@{#401460}