Issue 2073173002: Use the new loader mechanism to resolve URIs and load script files in gen_snapshot. This should all…

Issue 2073173002: Use the new loader mechanism to resolve URIs and load script files in gen_snapshot. This should all… (Closed)

Created:
4 years, 6 months ago by siva

Modified:
4 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use the new loader mechanism to resolve URIs and load script files in gen_snapshot. This should allow the package config resolution to work in gen_snapshot for flutter and dartium snapshot generation cases. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/11682cd4c7e4d5a3b6be863bc9e84d207fe922df

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -171 lines)			Patch
M	runtime/bin/dartutils.h	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View		5 chunks	+3 lines, -36 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	1 2 3 4 5	15 chunks	+58 lines, -109 lines	0 comments	Download
M	runtime/bin/loader.h	View		3 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/bin/loader.cc	View	1	11 chunks	+78 lines, -13 lines	0 comments	Download
M	runtime/bin/vmservice/loader.dart	View	1 2 3 4 5	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

siva

4 years, 6 months ago (2016-06-20 20:56:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #6 (id:100001) manually as
11682cd4c7e4d5a3b6be863bc9e84d207fe922df (presubmit successful).