Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2073123003: Update Windows start menu art (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Windows start menu art R=grt@chromium.org BUG=620817 Committed: https://crrev.com/bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2 Cr-Commit-Position: refs/heads/master@{#400804}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix sprintf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/installer/setup/install.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M win8/resources/Logo.png View Binary file 0 comments Download
M win8/resources/SmallLogo.png View Binary file 0 comments Download
M win8/resources/chrome.VisualElementsManifest.xml View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
scottmg
4 years, 6 months ago (2016-06-17 22:58:28 UTC) #1
grt (UTC plus 2)
lgtm w/ a fix https://codereview.chromium.org/2073123003/diff/1/chrome/installer/setup/install.cc File chrome/installer/setup/install.cc (right): https://codereview.chromium.org/2073123003/diff/1/chrome/installer/setup/install.cc#newcode412 chrome/installer/setup/install.cc:412: manifest_template.c_str(), elements_dir.c_str(), elements_dir.c_str())); one more ...
4 years, 6 months ago (2016-06-20 19:43:04 UTC) #2
scottmg
https://codereview.chromium.org/2073123003/diff/1/chrome/installer/setup/install.cc File chrome/installer/setup/install.cc (right): https://codereview.chromium.org/2073123003/diff/1/chrome/installer/setup/install.cc#newcode412 chrome/installer/setup/install.cc:412: manifest_template.c_str(), elements_dir.c_str(), elements_dir.c_str())); On 2016/06/20 19:43:04, grt (slow) wrote: ...
4 years, 6 months ago (2016-06-20 21:10:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073123003/20001
4 years, 6 months ago (2016-06-20 21:12:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 22:04:28 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 22:08:43 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bfe436f54ef0d0c9740bc1f6b68fa8bf34eaabe2
Cr-Commit-Position: refs/heads/master@{#400804}

Powered by Google App Engine
This is Rietveld 408576698