Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/crankshaft/hydrogen-instructions.h

Issue 2073123002: [builtins] Introduce proper Float64Cos and Float64Sin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix missing breaks Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.h
diff --git a/src/crankshaft/hydrogen-instructions.h b/src/crankshaft/hydrogen-instructions.h
index f54a91adc74d4632eb15bfe20cf3805dbde64adf..a13898a308b485a5521055b0644c88c876dbec3c 100644
--- a/src/crankshaft/hydrogen-instructions.h
+++ b/src/crankshaft/hydrogen-instructions.h
@@ -2453,9 +2453,11 @@ class HUnaryMathOperation final : public HTemplateInstruction<2> {
return Representation::Tagged();
} else {
switch (op_) {
+ case kMathCos:
case kMathFloor:
case kMathRound:
case kMathFround:
+ case kMathSin:
case kMathSqrt:
case kMathPowHalf:
case kMathLog:
@@ -2524,9 +2526,11 @@ class HUnaryMathOperation final : public HTemplateInstruction<2> {
// is tagged, and not when it is an unboxed double or unboxed integer.
SetChangesFlag(kNewSpacePromotion);
break;
+ case kMathCos:
case kMathFround:
case kMathLog:
case kMathExp:
+ case kMathSin:
case kMathSqrt:
case kMathPowHalf:
set_representation(Representation::Double());
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698