src/compiler/x64/code-generator-x64.cc - Issue 2073123002: [builtins] Introduce proper Float64Cos and Float64Sin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 2073123002: [builtins] Introduce proper Float64Cos and Float64Sin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix missing breaks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/code-generator-x64.cc

diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc

index d6df0081b355668145c80221d146c5d715ec3699..f444d45277174b02b47a56710c479227e1e52e56 100644

--- a/src/compiler/x64/code-generator-x64.cc

+++ b/src/compiler/x64/code-generator-x64.cc

@@ -876,6 +876,12 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

case kIeee754Float64Atanh:

ASSEMBLE_IEEE754_UNOP(atanh);

break;

+ case kIeee754Float64Cbrt:

+ ASSEMBLE_IEEE754_UNOP(cbrt);

+ break;

+ case kIeee754Float64Cos:

+ ASSEMBLE_IEEE754_UNOP(cos);

+ break;

case kIeee754Float64Exp:

ASSEMBLE_IEEE754_UNOP(exp);

break;

@@ -894,8 +900,8 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

case kIeee754Float64Log10:

ASSEMBLE_IEEE754_UNOP(log10);

break;

- case kIeee754Float64Cbrt:

- ASSEMBLE_IEEE754_UNOP(cbrt);

+ case kIeee754Float64Sin:

+ ASSEMBLE_IEEE754_UNOP(sin);

break;

case kX64Add32:

ASSEMBLE_BINOP(addl);

« no previous file with comments | « src/compiler/verifier.cc ('k') | src/crankshaft/arm/lithium-arm.h » ('j') | no next file with comments »