[test] Reduce number of variants that test/mjsunit/es6/tail-call-megatest.js checks.

test/mjsunit/es6/tail-call-megatest.js

Index: test/mjsunit/es6/tail-call-megatest.js
diff --git a/test/mjsunit/es6/tail-call-megatest.js b/test/mjsunit/es6/tail-call-megatest.js
index 8c563ea9765c57c5b3d92b8ca7a1344ff3bba4da..f05f45bd683b7622a7c300d4469f285b74450f9c 100644
--- a/test/mjsunit/es6/tail-call-megatest.js
+++ b/test/mjsunit/es6/tail-call-megatest.js
@@ -10,6 +10,7 @@ Error.prepareStackTrace = (error,stack) => {
   return error.message + "\n    at " + stack.join("\n    at ");
 }
 
+var verbose = arguments.indexOf("-v") >= 0;
 
 function checkStackTrace(expected) {
   var e = new Error();
@@ -340,33 +341,33 @@ function run_tests(shard) {
     return source;
   }
 
-  var f_args_variants = ["", "1", "1, 2"];
-  var g_args_variants = ["", "10", "10, 20"];
+  var f_args_variants = [/*"", "1",*/ "1, 2"];

[Michael Achenbach, 2016/06/17 11:09:21]

I have no idea what you exactly remove here. But won't we now miss coverage for
all these cases? Wouldn't it be useful to still exercise those cases but not in
a cartesian product but just flat? E.g.

1) "" + "" + true
2) "1" + "10" + true
3) "1, 2" + "10, 20" + false

[Igor Sheludko, 2016/06/17 11:15:47]

I think it's fine at this point to just exclude these cases. Some of them are
already covered by non-megatest tests.

+  var g_args_variants = [/*"", "10",*/ "10, 20"];
   var f_inlinable_variants = [true, false];
   var g_inlinable_variants = [true, false];
   // This is to avoid bailing out because of referencing new.target.
-  var check_new_target_variants = [true, false];
+  var check_new_target_variants = [/*true,*/ false];
   var deopt_mode_variants = ["none", "f", "g", "test"];
   var f_variants = [
       f_cfg_sloppy,
       f_cfg_strict,
       f_cfg_bound,
       f_cfg_proxy,
-      f_cfg_possibly_eval,
+//      f_cfg_possibly_eval,
   ];
   var g_variants = [
       g_cfg_normal,
-      g_cfg_reflect_apply,
+//      g_cfg_reflect_apply,
       g_cfg_function_apply,
-      g_cfg_function_apply_arguments_object,
+//      g_cfg_function_apply_arguments_object,
       g_cfg_function_call,
   ];
   var test_warmup_counts = [0, 1, 2];
 
   var iter = 0;
   var tests_executed = 0;
-  if (shard !== undefined) {
-//    print("Running shard #" + shard);
+  if (verbose && shard !== undefined) {
+    print("Running shard #" + shard);
   }
   f_variants.forEach((f_cfg) => {
     check_new_target_variants.forEach((check_new_target) => {
@@ -378,7 +379,9 @@ function run_tests(shard) {
                 g_inlinable_variants.forEach((g_inlinable) => {
                   test_warmup_counts.forEach((test_warmup_count) => {
                     if (shard !== undefined && (iter++) % SHARDS_COUNT != shard) {
-//                      print("skipping...");
+                      if (verbose) {
+                        print("skipping...");
+                      }
                       return;
                     }
                     tests_executed++;
@@ -396,8 +399,10 @@ function run_tests(shard) {
                       deopt_mode,
                     };
                     var source = test_template(cfg);
-//                    print("====================");
-//                    print(source);
+                    if (verbose) {
+                      // print("====================");
+                      // print(source);

[Michael Achenbach, 2016/06/17 11:09:21]

You keep those still commented out because they produce huge output?

[Igor Sheludko, 2016/06/17 11:15:47]

Yes. This output is needed only for debugging, while the other prints can give
useful info.

+                    }
                     eval(source);
                   });
                 });
@@ -408,7 +413,9 @@ function run_tests(shard) {
       });
     });
   });
-//  print("Number of tests executed: " + tests_executed);
+  if (verbose) {
+    print("Number of tests executed: " + tests_executed);
+  }
 }
 
 // Uncomment to run all the tests at once or use shard runners.