[test] Reduce number of variants that test/mjsunit/es6/tail-call-megatest.js checks.

[test] Reduce number of variants that test/mjsunit/es6/tail-call-megatest.js checks.

Committed: https://crrev.com/e4fba99bbbeee8786c9ee409229a3b866ea4e1a8
Cr-Commit-Position: refs/heads/master@{#37068}

[Igor Sheludko, 2016-06-17 09:49:08]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 09:49:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073103002/1

[Igor Sheludko, 2016-06-17 09:49:34]

ishell@chromium.org changed reviewers:
+ machenbach@chromium.org

[Igor Sheludko, 2016-06-17 09:49:34]

PTAL

[commit-bot: I haz the power, 2016-06-17 10:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 10:23:06]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Michael Achenbach, 2016-06-17 11:09:22]

https://codereview.chromium.org/2073103002/diff/1/test/mjsunit/es6/tail-call-...
File test/mjsunit/es6/tail-call-megatest.js (right):

https://codereview.chromium.org/2073103002/diff/1/test/mjsunit/es6/tail-call-...
test/mjsunit/es6/tail-call-megatest.js:344: var f_args_variants = [/*"", "1",*/
"1, 2"];
I have no idea what you exactly remove here. But won't we now miss coverage for
all these cases? Wouldn't it be useful to still exercise those cases but not in
a cartesian product but just flat? E.g.

1) "" + "" + true
2) "1" + "10" + true
3) "1, 2" + "10, 20" + false

https://codereview.chromium.org/2073103002/diff/1/test/mjsunit/es6/tail-call-...
test/mjsunit/es6/tail-call-megatest.js:404: // print(source);
You keep those still commented out because they produce huge output?

[Igor Sheludko, 2016-06-17 11:15:27]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 11:15:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073103002/20001

[Igor Sheludko, 2016-06-17 11:15:47]

https://codereview.chromium.org/2073103002/diff/1/test/mjsunit/es6/tail-call-...
File test/mjsunit/es6/tail-call-megatest.js (right):

https://codereview.chromium.org/2073103002/diff/1/test/mjsunit/es6/tail-call-...
test/mjsunit/es6/tail-call-megatest.js:344: var f_args_variants = [/*"", "1",*/
"1, 2"];
On 2016/06/17 11:09:21, Michael Achenbach wrote:
> I have no idea what you exactly remove here. But won't we now miss coverage
for
> all these cases? Wouldn't it be useful to still exercise those cases but not
in
> a cartesian product but just flat? E.g.
> 
> 1) "" + "" + true
> 2) "1" + "10" + true
> 3) "1, 2" + "10, 20" + false

I think it's fine at this point to just exclude these cases. Some of them are
already covered by non-megatest tests.

https://codereview.chromium.org/2073103002/diff/1/test/mjsunit/es6/tail-call-...
test/mjsunit/es6/tail-call-megatest.js:404: // print(source);
On 2016/06/17 11:09:21, Michael Achenbach wrote:
> You keep those still commented out because they produce huge output?

Yes. This output is needed only for debugging, while the other prints can give
useful info.

[commit-bot: I haz the power, 2016-06-17 11:45:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 11:45:10]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-06-17 12:06:55]

lgtm

[Igor Sheludko, 2016-06-17 12:27:41]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-17 12:27:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073103002/20001

[commit-bot: I haz the power, 2016-06-17 12:29:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 12:30:06]

Description was changed from

==========
[test] Reduce number of variants that test/mjsunit/es6/tail-call-megatest.js
checks.
==========

to

==========
[test] Reduce number of variants that test/mjsunit/es6/tail-call-megatest.js
checks.

Committed: https://crrev.com/e4fba99bbbeee8786c9ee409229a3b866ea4e1a8
Cr-Commit-Position: refs/heads/master@{#37068}
==========

[commit-bot: I haz the power, 2016-06-17 12:30:08]

Patchset 2 (id:??) landed as
https://crrev.com/e4fba99bbbeee8786c9ee409229a3b866ea4e1a8
Cr-Commit-Position: refs/heads/master@{#37068}