Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6000)

Unified Diff: chrome/renderer/autofill/form_autofill_browsertest.cc

Issue 2073093002: [Password Generation] Sends CSS classes inside autofill proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed useless FormStructure recreation in FormStructureTest.EncodeUploadRequest_WithCssClasses Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/form_autofill_browsertest.cc
diff --git a/chrome/renderer/autofill/form_autofill_browsertest.cc b/chrome/renderer/autofill/form_autofill_browsertest.cc
index 1531b23018dda47b2a559a6af3bf3a9b012f21fc..7ae881f2c15853c002f71e0e01582f3f9b13327f 100644
--- a/chrome/renderer/autofill/form_autofill_browsertest.cc
+++ b/chrome/renderer/autofill/form_autofill_browsertest.cc
@@ -2329,6 +2329,33 @@ TEST_F(FormAutofillTest, WebFormElementToFormData_AutocompleteOff_OnField) {
EXPECT_TRUE(form.fields[2].should_autocomplete);
}
+// Tests CSS classes are set.
+TEST_F(FormAutofillTest, WebFormElementToFormData_CssClasses) {
+ LoadHTML(
+ "<FORM name='TestForm' id='form' action='http://cnn.com' method='post' "
+ "autocomplete='off'>"
+ " <INPUT type='text' id='firstname' class='firstname_field' />"
+ " <INPUT type='text' id='lastname' class='lastname_field' />"
+ " <INPUT type='text' id='addressline1' />"
+ "</FORM>");
+
+ WebFrame* frame = GetMainFrame();
+ ASSERT_NE(nullptr, frame);
+
+ WebFormElement web_form =
+ frame->document().getElementById("form").to<WebFormElement>();
+ ASSERT_FALSE(web_form.isNull());
+
+ FormData form;
+ EXPECT_TRUE(WebFormElementToFormData(web_form, WebFormControlElement(),
+ EXTRACT_NONE, &form, nullptr));
+
+ EXPECT_EQ(3U, form.fields.size());
+ EXPECT_EQ(ASCIIToUTF16("firstname_field"), form.fields[0].css_classes);
+ EXPECT_EQ(ASCIIToUTF16("lastname_field"), form.fields[1].css_classes);
+ EXPECT_EQ(base::string16(), form.fields[2].css_classes);
+}
+
TEST_F(FormAutofillTest, ExtractForms) {
ExpectJohnSmithLabels(
"<FORM name='TestForm' action='http://cnn.com' method='post'>"
« no previous file with comments | « chrome/browser/autofill/autofill_server_browsertest.cc ('k') | components/autofill/content/renderer/form_autofill_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698