Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 207303004: Minor fix to regex inside compiler_version.py (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 9 months ago
Reviewers:
Lei Zhang, Nico, Inactive
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Minor fix to regex inside compiler_version.py These dots where meant to be literal dots, not anything. BUG=352046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258570

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/compiler_version.py View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
mithro-old
Small fix.
6 years, 9 months ago (2014-03-21 09:36:56 UTC) #1
Nico
lgtm
6 years, 9 months ago (2014-03-21 10:34:39 UTC) #2
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-21 11:15:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/207303004/1
6 years, 9 months ago (2014-03-21 11:16:11 UTC) #4
commit-bot: I haz the power
Change committed as 258570
6 years, 9 months ago (2014-03-21 14:15:58 UTC) #5
Inactive
On 2014/03/21 14:15:58, I haz the power (commit-bot) wrote: > Change committed as 258570 I ...
6 years, 9 months ago (2014-03-21 14:40:42 UTC) #6
Inactive
https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py File build/compiler_version.py (right): https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py#newcode31 build/compiler_version.py:31: version_re = re.compile(r"^GNU [^ ]+ .* (\d+)\.(\d+)\.*?$", re.M) The ...
6 years, 9 months ago (2014-03-21 14:45:09 UTC) #7
mithro-old
6 years, 9 months ago (2014-03-21 14:48:02 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/208313002/ by mithro@mithis.com.

The reason for reverting is: The second \. should have remained a .

Chris Dumez	
1 minute ago #7
Message was sent while issue was closed.
https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py
File build/compiler_version.py (right):

https://codereview.chromium.org/207303004/diff/1/build/compiler_version.py#ne...
build/compiler_version.py:31: version_re = re.compile(r"^GNU [^ ]+ .*
(\d+)\.(\d+)\.*?$", re.M)
The last "\.*" looks weird, I think it should be ".*".

Powered by Google App Engine
This is Rietveld 408576698