src/compiler/code-generator.cc - Issue 2072963003: Simplify AssemblerPositionsRecorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/code-generator.cc

Issue 2072963003: Simplify AssemblerPositionsRecorder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/code-generator.cc

diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc

index 701130c7829769baf10d9abc63f45f5f00d647e1..f3886593b14b5fadd4ccc27be037f88222ce42f1 100644

--- a/src/compiler/code-generator.cc

+++ b/src/compiler/code-generator.cc

@@ -399,7 +399,6 @@ void CodeGenerator::AssembleSourcePosition(Instruction* instr) {

if (source_position.IsUnknown()) return;

int code_pos = source_position.raw();

masm()->positions_recorder()->RecordPosition(code_pos);

- masm()->positions_recorder()->WriteRecordedPositions();

if (FLAG_code_comments) {

CompilationInfo* info = this->info();

if (!info->parse_info()) return;

« no previous file with comments | « src/assembler.cc ('k') | src/crankshaft/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »