third_party/WebKit/Source/modules/payments/PaymentResponse.cpp - Issue 2072963002: Remove PaymentResponse.totalAmount according to latest spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2072963002: Remove PaymentResponse.totalAmount according to latest spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/android/payments/no_shipping.js ('K') | « third_party/WebKit/Source/modules/payments/PaymentResponse.h ('k') | third_party/WebKit/Source/modules/payments/PaymentResponse.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

index e79a75d89936ed83bccd849646cf6cf296640e25..7b566af41782fcdda4b447fe39929cd0da369067 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

@@ -28,7 +28,6 @@ namespace blink {

PaymentResponse::PaymentResponse(mojom::blink::PaymentResponsePtr response, PaymentCompleter* paymentCompleter)

: m_methodName(response->method_name)

- , m_totalAmount(response->total_amount->To<CurrencyAmount>())

, m_stringifiedDetails(response->stringified_details)

, m_shippingAddress(response->shipping_address ? new PaymentAddress(std::move(response->shipping_address)) : nullptr)

, m_payerEmail(response->payer_email)