Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Issue 2072963002: Remove PaymentResponse.totalAmount according to latest spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/data/android/payments/no_shipping.js ('K') | « third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html ('k') | third_party/WebKit/Source/modules/payments/PaymentResponse.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentResponse.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
index 7984615d03bc4fc9c0e541f5250d07e323a8419d..88bece1e504102e138b68cff8eabe15b467cd1af 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
@@ -553,7 +553,6 @@ TEST(PaymentRequestTest, ResolveShowPromiseWithRequestPayerEmailTrueAndValidPaye
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_email = "abc@gmail.com";
ScriptValue outValue;
@@ -576,7 +575,6 @@ TEST(PaymentRequestTest, RejectShowPromiseWithRequestPayerEmailTrueAndEmptyPayer
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_email = "";
request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
@@ -594,7 +592,6 @@ TEST(PaymentRequestTest, RejectShowPromiseWithRequestPayerEmailTrueAndNullPayerE
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_email = String();
request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
@@ -612,7 +609,6 @@ TEST(PaymentRequestTest, RejectShowPromiseWithRequestPayerEmailFalseAndNonNullPa
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_email = "";
request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
@@ -630,7 +626,6 @@ TEST(PaymentRequestTest, ResolveShowPromiseWithRequestPayerEmailFalseAndNullPaye
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_email = String();
ScriptValue outValue;
@@ -653,7 +648,6 @@ TEST(PaymentRequestTest, ResolveShowPromiseWithRequestPayerPhoneTrueAndValidPaye
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_phone = "0123";
ScriptValue outValue;
@@ -676,7 +670,6 @@ TEST(PaymentRequestTest, RejectShowPromiseWithRequestPayerPhoneTrueAndEmptyPayer
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_phone = "";
request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
@@ -694,7 +687,6 @@ TEST(PaymentRequestTest, RejectShowPromiseWithRequestPayerPhoneTrueAndNullPayerP
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_phone = String();
request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
@@ -712,7 +704,6 @@ TEST(PaymentRequestTest, RejectShowPromiseWithRequestPayerPhoneFalseAndNonNulPay
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_phone = "";
request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
@@ -730,7 +721,6 @@ TEST(PaymentRequestTest, ResolveShowPromiseWithRequestPayerPhoneFalseAndNullPaye
PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
EXPECT_FALSE(scope.getExceptionState().hadException());
mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
- response->total_amount = mojom::blink::CurrencyAmount::New();
response->payer_phone = String();
ScriptValue outValue;
« chrome/test/data/android/payments/no_shipping.js ('K') | « third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html ('k') | third_party/WebKit/Source/modules/payments/PaymentResponse.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentResponse.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698