chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc - Issue 2072933002: Add sampling of unknown filetypes in download protection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

Issue 2072933002: Add sampling of unknown filetypes in download protection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add int values for histograms to ensure they match Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc b/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

index 0412ef35fe422190b3e6cf7196e0bbb544cb35a6..b60f4cffbfa9d106f9103de0897df7eb6f6cf67f 100644

--- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

@@ -59,7 +59,7 @@ bool IsBinaryDownloadForCurrentOS(

// should also be updated so that the IsBinaryDownloadForCurrentOS() will

// return true for that DownloadType as appropriate.

static_assert(ClientDownloadRequest::DownloadType_MAX ==

- ClientDownloadRequest::PPAPI_SAVE_REQUEST,

+ ClientDownloadRequest::SAMPLED_UNSUPPORTED_FILE,

"Update logic below");

// Platform-specific types are relevant only for their own platforms.

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »