Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4485)

Unified Diff: chrome/browser/safe_browsing/download_protection_service.h

Issue 2072933002: Add sampling of unknown filetypes in download protection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_protection_service.h
diff --git a/chrome/browser/safe_browsing/download_protection_service.h b/chrome/browser/safe_browsing/download_protection_service.h
index 83ed3596582f8b377d946503aa4e964a94bfbeb4..181e5b18606c885d0038bef5cea4235b0874de41 100644
--- a/chrome/browser/safe_browsing/download_protection_service.h
+++ b/chrome/browser/safe_browsing/download_protection_service.h
@@ -107,8 +107,9 @@ class DownloadProtectionService {
// Returns true iff the download specified by |info| should be scanned by
// CheckClientDownload() for malicious content.
- virtual bool IsSupportedDownload(const content::DownloadItem& item,
- const base::FilePath& target_path) const;
+ virtual bool IsSupportedDownload(
+ const content::DownloadItem& item,
+ const base::FilePath& target_path) const;
virtual void CheckPPAPIDownloadRequest(
const GURL& requestor_url,
@@ -157,7 +158,7 @@ class DownloadProtectionService {
protected:
// Enum to keep track why a particular download verdict was chosen.
- // This is used to keep some stats around.
+ // Used for UMA metrics. Do not reorder.
enum DownloadCheckResultReason {
REASON_INVALID_URL,
REASON_SB_DISABLED,
@@ -183,6 +184,7 @@ class DownloadProtectionService {
REASON_DOWNLOAD_POTENTIALLY_UNWANTED,
REASON_UNSUPPORTED_URL_SCHEME,
REASON_MANUAL_BLACKLIST,
+ REASON_SAMPLED_UNSUPPORTED_FILE,
REASON_MAX // Always add new values before this one.
};

Powered by Google App Engine
This is Rietveld 408576698