Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2072923002: Gerrit git cl upload: Remove --no-squash warning message. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 6 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gerrit git cl upload: Remove --no-squash warning message. First, it's wrong because of instruction in it is ineffective. Second, it was also shown during --squash upload, which is completely wrong. TBR=sergiyb@chromium.org BUG=611892 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/edbf9a3e853be0f58240a36d3063e00d9d2d9ad1

Patch Set 1 #

Patch Set 2 : fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M git_cl.py View 1 chunk +0 lines, -12 lines 0 comments Download
M tests/git_cl_test.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
tandrii(chromium)
4 years, 6 months ago (2016-06-16 22:41:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072923002/1
4 years, 6 months ago (2016-06-16 22:41:07 UTC) #3
tandrii(chromium)
FYI jmadill@: prior to this CL, a message about --no-squash was shown even during --squash ...
4 years, 6 months ago (2016-06-16 22:44:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072923002/20001
4 years, 6 months ago (2016-06-16 22:46:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/edbf9a3e853be0f58240a36d3063e00d9d2d9ad1
4 years, 6 months ago (2016-06-16 22:49:40 UTC) #9
Jamie Madill
4 years, 6 months ago (2016-06-17 00:42:54 UTC) #10
Message was sent while issue was closed.
On 2016/06/16 22:49:40, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/tools/depot_tools/+/edbf9a3e853be0...

Weird, it didn't squash my CLs when I uploaded.

Powered by Google App Engine
This is Rietveld 408576698