mojom/generators/c/cgen/header.go - Issue 2072903002: C bindings pt3: Type table definitions and barebones files to get generated code to compile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/generators/c/cgen/header.go

Issue 2072903002: C bindings pt3: Type table definitions and barebones files to get generated code to compile. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: tiny cleanup in the generator Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/c/bindings/lib/type_table.h ('K') | « mojo/public/tools/bindings/mojom_tool/bin/mac64/generators/c.sha1 ('k') | mojom/generators/c/cgen/type_table.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojom/generators/c/cgen/header.go

diff --git a/mojom/generators/c/cgen/header.go b/mojom/generators/c/cgen/header.go

index 4814c5cdba7bc93960cfbe8196f273b3159e24af..339f72387c55b3020662670065af4dde41c1bdca 100644

--- a/mojom/generators/c/cgen/header.go

+++ b/mojom/generators/c/cgen/header.go

@@ -189,7 +189,7 @@ func resolveValue(fileGraph *mojom_files.MojomFileGraph, value mojom_types.Value

func NewConstantTemplate(fileGraph *mojom_files.MojomFileGraph, mojomConstant mojom_types.DeclaredConstant) ConstantTemplate {

var type_text string

switch mojomConstant.Type.(type) {

- // We can't type string constants as a 'union MojomStringPtr' since it

+ // We can't type string constants as a 'union MojomStringHeaderPtr' since it

// involves some setup and prevents immediate consumption. const char* should

// suffice.

case *mojom_types.TypeStringType: