Issue 2072883004: Code changes to avoid Firefox debug 'error' lint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2072883004: Code changes to avoid Firefox debug 'error' lint warnings. (Closed)

Created:
4 years, 6 months ago by sra1

Modified:
4 years, 6 months ago

Reviewers:
Harry Terkelsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Code changes to avoid Firefox debug 'error' lint warnings. Firefox produces many SyntaxErrors and TypeErrors for what are really linter issues. Improve compile-time and run-time codegen to avoid these warnings. BUG= R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/909ec27b10fe05c2ceb9871a7a06ad077ced30f1

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -8 lines)			Patch
	M	pkg/compiler/lib/src/ssa/codegen.dart	View		1 chunk	+19 lines, -2 lines	0 comments	Download
	M	sdk/lib/_internal/js_runtime/lib/js_helper.dart	View		4 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

4 years, 6 months ago (2016-06-17 20:05:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
909ec27b10fe05c2ceb9871a7a06ad077ced30f1 (presubmit successful).