Update FormatOriginForSecurityDisplay() comments

Update FormatOriginForSecurityDisplay() comments

This patch updated comments for FormatOriginForSecurityDisplay() function.
Also updated //components/url_formatter/OWNERS to
include FormatOriginForSecurityDisplay() function.

BUG=612511
Committed: https://crrev.com/72b749dad66cb8f0f4a3247e076ebdce0330e4de
Cr-Commit-Position: refs/heads/master@{#400505}

[juncai, 2016-06-16 20:03:27]

juncai@chromium.org changed reviewers:
+ brettw@chromium.org, palmer@chromium.org

[juncai, 2016-06-16 20:03:28]

palmer@chromium.org: Please make a security review.

brettw@chromium.org: Please take a look.

[palmer, 2016-06-16 22:20:00]

https://codereview.chromium.org/2072863002/diff/1/components/url_formatter/el...
File components/url_formatter/elide_url.h (right):

https://codereview.chromium.org/2072863002/diff/1/components/url_formatter/el...
components/url_formatter/elide_url.h:89: // they're regarded safe.
Maybe say what "safe" means in this context. Also, the implementation of this
function doesn't seem to make any direct decisions about IDN safety.

[juncai, 2016-06-16 22:36:50]

https://codereview.chromium.org/2072863002/diff/1/components/url_formatter/el...
File components/url_formatter/elide_url.h (right):

https://codereview.chromium.org/2072863002/diff/1/components/url_formatter/el...
components/url_formatter/elide_url.h:89: // they're regarded safe.
On 2016/06/16 22:20:00, palmer wrote:
> Maybe say what "safe" means in this context. Also, the implementation of this
> function doesn't seem to make any direct decisions about IDN safety.

Right. This paragraph is removed.

[palmer, 2016-06-16 23:17:55]

lgtm

[brettw, 2016-06-17 20:46:13]

lgtm

[juncai, 2016-06-17 21:13:51]

Description was changed from

==========
Update FormatOriginForSecurityDisplay() comments

This patch updated comments for FormatOriginForSecurityDisplay() function.
Also updated //components/url_formatter/OWNERS to
includeFormatOriginForSecurityDisplay() function.

BUG=612511
==========

to

==========
Update FormatOriginForSecurityDisplay() comments

This patch updated comments for FormatOriginForSecurityDisplay() function.
Also updated //components/url_formatter/OWNERS to
include FormatOriginForSecurityDisplay() function.

BUG=612511
==========

[juncai, 2016-06-17 21:14:29]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-06-17 21:15:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072863002/20001

[commit-bot: I haz the power, 2016-06-17 21:19:50]

Description was changed from

==========
Update FormatOriginForSecurityDisplay() comments

This patch updated comments for FormatOriginForSecurityDisplay() function.
Also updated //components/url_formatter/OWNERS to
include FormatOriginForSecurityDisplay() function.

BUG=612511
==========

to

==========
Update FormatOriginForSecurityDisplay() comments

This patch updated comments for FormatOriginForSecurityDisplay() function.
Also updated //components/url_formatter/OWNERS to
include FormatOriginForSecurityDisplay() function.

BUG=612511
==========

[commit-bot: I haz the power, 2016-06-17 21:19:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 21:21:18]

Description was changed from

==========
Update FormatOriginForSecurityDisplay() comments

This patch updated comments for FormatOriginForSecurityDisplay() function.
Also updated //components/url_formatter/OWNERS to
include FormatOriginForSecurityDisplay() function.

BUG=612511
==========

to

==========
Update FormatOriginForSecurityDisplay() comments

This patch updated comments for FormatOriginForSecurityDisplay() function.
Also updated //components/url_formatter/OWNERS to
include FormatOriginForSecurityDisplay() function.

BUG=612511

Committed: https://crrev.com/72b749dad66cb8f0f4a3247e076ebdce0330e4de
Cr-Commit-Position: refs/heads/master@{#400505}
==========

[commit-bot: I haz the power, 2016-06-17 21:21:19]

Patchset 2 (id:??) landed as
https://crrev.com/72b749dad66cb8f0f4a3247e076ebdce0330e4de
Cr-Commit-Position: refs/heads/master@{#400505}