Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: runtime/vm/flow_graph_compiler_dbc.cc

Issue 2072823002: VM: Fix frame size computation for optimized DBC code (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_allocator.cc ('k') | runtime/vm/intermediate_language_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_dbc.cc
diff --git a/runtime/vm/flow_graph_compiler_dbc.cc b/runtime/vm/flow_graph_compiler_dbc.cc
index 5a60cb7d9b5a86c7e4056462ccfb305fdfbc53f7..af756db0895dcdf660228ed3c401865d6fc9ce0c 100644
--- a/runtime/vm/flow_graph_compiler_dbc.cc
+++ b/runtime/vm/flow_graph_compiler_dbc.cc
@@ -237,9 +237,9 @@ void FlowGraphCompiler::GenerateAssertAssignable(TokenPosition token_pos,
AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id, token_pos);
if (is_optimizing()) {
// Assert assignable keeps the instance on the stack as the result,
- // all other arguments are popped. Since there may have been a GC during
- // the runtime call, we have to reload the instance.
- __ PopLocal(locs->out(0).reg());
+ // all other arguments are popped.
+ ASSERT(locs->out(0).reg() == locs->in(0).reg());
+ __ Drop1();
}
}
« no previous file with comments | « runtime/vm/flow_graph_allocator.cc ('k') | runtime/vm/intermediate_language_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698