tools/viewer/sk_app/android/GLWindowContext_android.cpp - Issue 2072813002: Revert of Lots of progress switching to SkColorSpace rather than SkColorProfileType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/viewer/sk_app/android/GLWindowContext_android.cpp

Issue 2072813002: Revert of Lots of progress switching to SkColorSpace rather than SkColorProfileType (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/viewer/sk_app/android/GLWindowContext_android.cpp

diff --git a/tools/viewer/sk_app/android/GLWindowContext_android.cpp b/tools/viewer/sk_app/android/GLWindowContext_android.cpp

index be62ab2b68e066979b200efae70f8bf56c7b18ab..79425b41155237a207f19683492267a6ab6da4f2 100644

--- a/tools/viewer/sk_app/android/GLWindowContext_android.cpp

+++ b/tools/viewer/sk_app/android/GLWindowContext_android.cpp

@@ -99,8 +99,7 @@

EGL_NONE,

};

const EGLint* windowAttribs = nullptr;

- auto srgbColorSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named);

- if (srgbColorSpace == params.fColorSpace && majorVersion == 1 && minorVersion >= 2) {

+ if (kSRGB_SkColorProfileType == params.fProfileType && majorVersion == 1 && minorVersion >= 2) {

windowAttribs = srgbWindowAttribs;

}

« no previous file with comments | « tools/viewer/sk_app/WindowContext.cpp ('k') | tools/viewer/sk_app/android/RasterWindowContext_android.cpp » ('j') | no next file with comments »