Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: xfa/fde/ifde_txtedtengine.h

Issue 2072803002: Make code compile with clang_use_chrome_plugin (final) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: tidy Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fde/ifde_txtedtengine.h
diff --git a/xfa/fde/ifde_txtedtengine.h b/xfa/fde/ifde_txtedtengine.h
index 8ecf46e5c84e40b8669322479091d951f94e3b8f..48b155f1fce9efb796886b274cdfc5b716bf6721 100644
--- a/xfa/fde/ifde_txtedtengine.h
+++ b/xfa/fde/ifde_txtedtengine.h
@@ -82,26 +82,7 @@ enum FDE_TXTEDIT_LINEEND {
};
struct FDE_TXTEDTPARAMS {
- FDE_TXTEDTPARAMS()
- : fPlateWidth(0),
- fPlateHeight(0),
- nLineCount(0),
- dwLayoutStyles(0),
- dwAlignment(0),
- dwMode(0),
- pFont(nullptr),
- fFontSize(10.0f),
- dwFontColor(0xff000000),
- fLineSpace(10.0f),
- fTabWidth(36),
- bTabEquidistant(FALSE),
- wDefChar(0xFEFF),
- wLineBreakChar('\n'),
- nCharRotation(0),
- nLineEnd(0),
- nHorzScale(100),
- fCharSpace(0),
- pEventSink(nullptr) {}
+ FDE_TXTEDTPARAMS();
FX_FLOAT fPlateWidth;
FX_FLOAT fPlateHeight;
@@ -131,10 +112,17 @@ enum FDE_TXTEDT_TEXTCHANGE_TYPE {
};
struct FDE_TXTEDT_TEXTCHANGE_INFO {
+ FDE_TXTEDT_TEXTCHANGE_INFO();
+ ~FDE_TXTEDT_TEXTCHANGE_INFO();
+
int32_t nChangeType;
CFX_WideString wsInsert;
CFX_WideString wsDelete;
CFX_WideString wsPrevText;
};
+inline FDE_TXTEDT_TEXTCHANGE_INFO::FDE_TXTEDT_TEXTCHANGE_INFO() {}
Lei Zhang 2016/06/17 03:10:05 Maybe put these in xfa/fde/cfde_txtedtengine.cpp i
Wei Li 2016/06/17 21:47:44 Done.
+
+inline FDE_TXTEDT_TEXTCHANGE_INFO::~FDE_TXTEDT_TEXTCHANGE_INFO() {}
+
#endif // XFA_FDE_IFDE_TXTEDTENGINE_H_

Powered by Google App Engine
This is Rietveld 408576698