fxjse/include/cfxjse_value.h - Issue 2072803002: Make code compile with clang_use_chrome_plugin (final)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fxjse/include/cfxjse_value.h

Issue 2072803002: Make code compile with clang_use_chrome_plugin (final) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: tidy Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fxjse/include/cfxjse_value.h

diff --git a/fxjse/include/cfxjse_value.h b/fxjse/include/cfxjse_value.h

index 74b4bab2e2aa39a3d1c273955d9d2bd59b773a64..8dd6ef8d93c74018c70ac0f3de8909a56e73b993 100644

--- a/fxjse/include/cfxjse_value.h

+++ b/fxjse/include/cfxjse_value.h

@@ -11,7 +11,8 @@

class CFXJSE_Value {

public:

- CFXJSE_Value(v8::Isolate* pIsolate) : m_pIsolate(pIsolate) {}

+ CFXJSE_Value(v8::Isolate* pIsolate);

+ ~CFXJSE_Value();

FX_BOOL IsUndefined() const {

if (m_hValue.IsEmpty()) {