Issue 2072803002: Make code compile with clang_use_chrome_plugin (final)

Issue 2072803002: Make code compile with clang_use_chrome_plugin (final) (Closed)

Created:
4 years, 6 months ago by Wei Li

Modified:
4 years, 6 months ago

Reviewers:
Lei Zhang, dsinclair

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

More Reviews

Description

Make code compile with clang_use_chrome_plugin (final) This change mainly contains files in xfa/ and fxjse/ directories which were not covered by previous changes. This is part of the efforts to make PDFium code compilable by Clang chromium style plugins. After this change, PDFium can be compiled with "clang_use_chrome_plugin=true" for GN build. Since clang_use_chrome_plugin is true by default, we no longer need to set this parameter explicitly. The changes are mainly the following: -- move inline constructor/destructor of complex class/struct out-of-line; -- add constructor/destructor of complex class/struct if not explicitly defined; -- add explicit out-of-line copy constructor when needed; -- move inline virtual functions out-of-line; -- Properly mark virtual functions with 'override'; -- some minor cleanups; BUG=pdfium:469 Committed: https://pdfium.googlesource.com/pdfium/+/eec3a366adbfada36b98f1de651546ee09df8fc0

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : tidy #

Total comments: 26

Patch Set 4 : address comments #

Patch Set 5 : small fixes #

Patch Set 6 : rebase #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1023 lines, -543 lines)			Patch
M	BUILD.gn	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	fxjse/class.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	fxjse/include/cfxjse_class.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	fxjse/include/cfxjse_value.h	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	fxjse/runtime.h	View	1 2	2 chunks	+13 lines, -5 lines	0 comments	Download
M	fxjse/runtime.cpp	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	fxjse/value.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	xfa.gyp	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	xfa/fde/cfde_txtedtengine.cpp	View	1 2 3	1 chunk	+25 lines, -0 lines	0 comments	Download
M	xfa/fde/css/fde_css.h	View	1 2 3	6 chunks	+17 lines, -7 lines	0 comments	Download
A	xfa/fde/css/fde_css.cpp	View	1 2 3	1 chunk	+27 lines, -0 lines	0 comments	Download
M	xfa/fde/css/fde_csscache.h	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	xfa/fde/css/fde_csscache.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	xfa/fde/css/fde_cssdatatable.h	View	1 2 3 4	3 chunks	+25 lines, -51 lines	0 comments	Download
M	xfa/fde/css/fde_cssdatatable.cpp	View	1	2 chunks	+72 lines, -0 lines	0 comments	Download
M	xfa/fde/css/fde_cssstyleselector.h	View	1 2 3	5 chunks	+56 lines, -220 lines	0 comments	Download
M	xfa/fde/css/fde_cssstyleselector.cpp	View	1 2	6 chunks	+250 lines, -0 lines	0 comments	Download
M	xfa/fde/css/fde_cssstylesheet.h	View	1 2 3	3 chunks	+29 lines, -32 lines	0 comments	Download
M	xfa/fde/css/fde_cssstylesheet.cpp	View	1 2	16 chunks	+88 lines, -1 line	0 comments	Download
M	xfa/fde/css/fde_csssyntax.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	xfa/fde/fde_object.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	xfa/fde/ifde_txtedtengine.h	View	1 2 3	2 chunks	+4 lines, -20 lines	0 comments	Download
M	xfa/fde/tto/fde_textout.h	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	xfa/fde/xml/fde_xml_imp.h	View	1 2 3 4	7 chunks	+22 lines, -22 lines	0 comments	Download
M	xfa/fde/xml/fde_xml_imp.cpp	View	1 2 3	44 chunks	+109 lines, -0 lines	0 comments	Download
M	xfa/fgas/crt/fgas_stream.cpp	View		6 chunks	+65 lines, -53 lines	0 comments	Download
M	xfa/fgas/crt/fgas_utils.h	View		5 chunks	+10 lines, -5 lines	0 comments	Download
M	xfa/fgas/crt/fgas_utils.cpp	View		2 chunks	+14 lines, -8 lines	0 comments	Download
M	xfa/fgas/font/fgas_stdfontmgr.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	xfa/fgas/font/fgas_stdfontmgr.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	xfa/fgas/layout/fgas_rtfbreak.h	View	1	7 chunks	+34 lines, -60 lines	0 comments	Download
M	xfa/fgas/layout/fgas_rtfbreak.cpp	View	1 2	1 chunk	+46 lines, -0 lines	0 comments	Download
M	xfa/fgas/layout/fgas_textbreak.h	View	1 2 3	6 chunks	+11 lines, -39 lines	0 comments	Download
M	xfa/fgas/layout/fgas_textbreak.cpp	View	1 2	1 chunk	+46 lines, -0 lines	0 comments	Download
M	xfa/fxgraphics/cfx_graphics.cpp	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	xfa/fxgraphics/include/cfx_graphics.h	View		1 chunk	+1 line, -10 lines	0 comments	Download

Messages

Total messages: 11 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

https://codereview.chromium.org/2072803002/diff/60001/xfa/fde/css/fde_css.h File xfa/fde/css/fde_css.h (right): https://codereview.chromium.org/2072803002/diff/60001/xfa/fde/css/fde_css.h#newcode706 xfa/fde/css/fde_css.h:706: inline FDE_CSSVALUETYPE IFDE_CSSPrimitiveValue::GetType() const { Put these in xfa/fde/css/fde_cssdatatable.cpp? ...

4 years, 6 months ago (2016-06-17 03:10:06 UTC) #4

Wei Li

ptal, thanks https://codereview.chromium.org/2072803002/diff/60001/xfa/fde/css/fde_css.h File xfa/fde/css/fde_css.h (right): https://codereview.chromium.org/2072803002/diff/60001/xfa/fde/css/fde_css.h#newcode706 xfa/fde/css/fde_css.h:706: inline FDE_CSSVALUETYPE IFDE_CSSPrimitiveValue::GetType() const { On 2016/06/17 ...

4 years, 6 months ago (2016-06-17 21:47:45 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072803002/120001

4 years, 6 months ago (2016-06-18 13:25:17 UTC) #9

commit-bot: I haz the power

Description was changed from ========== Make code compile with clang_use_chrome_plugin (final) This change mainly contains ...

4 years, 6 months ago (2016-06-18 13:25:40 UTC) #10

Message was sent while issue was closed.

Description was changed from

==========
Make code compile with clang_use_chrome_plugin (final)

This change mainly contains files in xfa/ and fxjse/ directories
which were not covered by previous changes.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins. After this change, PDFium can be
compiled with "clang_use_chrome_plugin=true" for GN build. Since
clang_use_chrome_plugin is true by default, we no longer need to
set this parameter explicitly.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
==========

to

==========
Make code compile with clang_use_chrome_plugin (final)

This change mainly contains files in xfa/ and fxjse/ directories
which were not covered by previous changes.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins. After this change, PDFium can be
compiled with "clang_use_chrome_plugin=true" for GN build. Since
clang_use_chrome_plugin is true by default, we no longer need to
set this parameter explicitly.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469

Committed:
https://pdfium.googlesource.com/pdfium/+/eec3a366adbfada36b98f1de651546ee09df...
==========

commit-bot: I haz the power

4 years, 6 months ago (2016-06-18 13:25:41 UTC) #11

Message was sent while issue was closed.

Committed patchset #6 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/eec3a366adbfada36b98f1de651546ee09df...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages