Fix issue: icons for the apps are flickering while launching.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   'use strict';
 
   /**
    * A lookup helper function to find the first node that has an id (starting
    * at |node| and going up the parent chain).
@@ skipping 14 matching lines @@
    */
   var ExtensionsList = cr.ui.define('div');
 
   /**
    * @type {Object.<string, boolean>} A map from extension id to a boolean
    *     indicating whether the incognito warning is showing. This persists
    *     between calls to decorate.
    */
   var butterBarVisibility = {};
 
+  /**
+   * @type {Object.<string, string>} A map from extension id to a icon url
+   *     with timestamp. The timestamp is a query string to prevent the
+   *     icon from caching and is recorded when the user click the 'Reload'
+   *     link. It is used to refresh the icon of an unpacked extension.
+   *     This persists between calls to decorate.
+   */
+  var extensionReloadedIconURL = {};
+
   ExtensionsList.prototype = {
     __proto__: HTMLDivElement.prototype,
 
     /** @override */
     decorate: function() {
       this.textContent = '';
 
       this.showExtensionNodes_();
     },
 
@@ skipping 45 matching lines @@
         node.classList.add('inactive-extension');
 
       if (!extension.userModifiable)
         node.classList.add('may-not-disable');
 
       var idToHighlight = this.getIdQueryParam_();
       if (node.id == idToHighlight)
         node.classList.add('extension-highlight');
 
       var item = node.querySelector('.extension-list-item');
-      var extensionIconUrl = extension.icon;
-      if (extension.allow_reload)
-        extensionIconUrl = extension.icon + '?' + Date.now();
-      item.style.backgroundImage = 'url(' + extensionIconUrl + ')';
+      if (extensionReloadedIconURL[extension.id]) {
+        item.style.backgroundImage =
+            'url(' + extensionReloadedIconURL[extension.id] + ')';
+      } else {
+        item.style.backgroundImage = 'url(' + extension.icon + ')';
+      }
 
       var title = node.querySelector('.extension-title');
       title.textContent = extension.name;
 
       var version = node.querySelector('.extension-version');
       version.textContent = extension.version;
 
       var locationText = node.querySelector('.location-text');
       locationText.textContent = extension.locationText;
 
@@ skipping 61 matching lines @@
                 extension.homepageProvided ? 'extensionSettingsVisitWebsite' :
                                              'extensionSettingsVisitWebStore');
         siteLink.hidden = false;
       }
 
       if (extension.allow_reload) {
         // The 'Reload' link.
         var reload = node.querySelector('.reload-link');
         reload.addEventListener('click', function(e) {
           chrome.send('extensionSettingsReload', [extension.id]);
+          extensionReloadedIconURL[extension.id] = extension.icon + '?' +
+                                                   new Date().getTime();

[not at google - send to devlin, 2013/07/26 16:48:07]

if the icon changes will this assignment happen before or after it completes?
because if it's after.. this won't work.

[zhchbin, 2013/07/29 15:43:59]

However, I couldn't make sure I got your meaning of these words exactly. Could
you please offer me more information about your case?

[not at google - send to devlin, 2013/07/29 17:26:24]

Like this:

1. Extension changes its icon URL in the manifest.
2. Click reload
3. extensionReloadedIconURL caches the URL, but that includes the icon url.
4. extension is reloaded but uses the old value for extension.icon so it doesn't
change

can you try these steps with this patch?

         });
         reload.hidden = false;
 
         if (extension.is_platform_app) {
           // The 'Launch' link.
           var launch = node.querySelector('.launch-link');
           launch.addEventListener('click', function(e) {
             chrome.send('extensionSettingsLaunch', [extension.id]);
           });
           launch.hidden = false;
@@ skipping 123 matching lines @@
       }
 
       this.appendChild(node);
     }
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });