Check for some potential subheap allocation failures.

Check for some potential subheap allocation failures.

Need to make sure we can allocate areas larger than our specified
subheap sizes, and deal with potential fragmentation in the main
system heap.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2072763002

Committed: https://skia.googlesource.com/skia/+/6dc3af4499893045f7b187d5d85bc785b6e44baa

[jvanverth1, 2016-06-16 16:58:42]

Description was changed from

==========
Check for some potential subheap allocation failures.

Need to make sure we can allocate areas larger than our specified
subheap sizes, and deal with potential fragmentation in the main
system heap.
==========

to

==========
Check for some potential subheap allocation failures.

Need to make sure we can allocate areas larger than our specified
subheap sizes, and deal with potential fragmentation in the main
system heap.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2072763002
==========

[jvanverth1, 2016-06-16 16:59:32]

jvanverth@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-06-16 18:55:23]

https://codereview.chromium.org/2072763002/diff/1/src/gpu/vk/GrVkMemory.cpp
File src/gpu/vk/GrVkMemory.cpp (right):

https://codereview.chromium.org/2072763002/diff/1/src/gpu/vk/GrVkMemory.cpp#n...
src/gpu/vk/GrVkMemory.cpp:547: if (0 == alloc.fSize) {
How does this affect the SingleAlloc guys? Once we're done with them do we no
longer want to try and reuse their memory?

[jvanverth1, 2016-06-16 20:26:53]

https://codereview.chromium.org/2072763002/diff/1/src/gpu/vk/GrVkMemory.cpp
File src/gpu/vk/GrVkMemory.cpp (right):

https://codereview.chromium.org/2072763002/diff/1/src/gpu/vk/GrVkMemory.cpp#n...
src/gpu/vk/GrVkMemory.cpp:547: if (0 == alloc.fSize) {
On 2016/06/16 18:55:23, egdaniel wrote:
> How does this affect the SingleAlloc guys? Once we're done with them do we no
> longer want to try and reuse their memory?

Anything that is in a GrVkSubHeap, whether it's suballoc'ed or is a single alloc
in that heap, has a positive value for fSize. I've added some asserts to, um,
assert that.

[egdaniel, 2016-06-16 20:36:24]

lgtm

[jvanverth1, 2016-06-16 20:36:48]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-06-16 20:37:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072763002/20001

[commit-bot: I haz the power, 2016-06-16 21:05:14]

Description was changed from

==========
Check for some potential subheap allocation failures.

Need to make sure we can allocate areas larger than our specified
subheap sizes, and deal with potential fragmentation in the main
system heap.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2072763002
==========

to

==========
Check for some potential subheap allocation failures.

Need to make sure we can allocate areas larger than our specified
subheap sizes, and deal with potential fragmentation in the main
system heap.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2072763002

Committed:
https://skia.googlesource.com/skia/+/6dc3af4499893045f7b187d5d85bc785b6e44baa
==========

[commit-bot: I haz the power, 2016-06-16 21:05:17]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6dc3af4499893045f7b187d5d85bc785b6e44baa