[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668, 620950
R=dpranke@chromium.org

Originally Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Reverted: https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf

Committed: https://crrev.com/e10a42e0d13e56e035a290b66a873442a7f71cf7
Cr-Commit-Position: refs/heads/master@{#400570}

[sdefresne, 2016-06-17 17:17:28]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-06-17 17:17:28]

https://codereview.chromium.org/2072713005/diff/20001/build/toolchain/mac/cop...
File build/toolchain/mac/copy_bundle_data.py (right):

https://codereview.chromium.org/2072713005/diff/20001/build/toolchain/mac/cop...
build/toolchain/mac/copy_bundle_data.py:104: subprocess.check_call(
I'm not sure this is correct, see my (long) comment on
https://codereview.chromium.org/2076853003/.

[Robert Sesek, 2016-06-17 22:39:18]

Description was changed from

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668
R=dpranke@chromium.org

Originally Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Reverted: https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf
==========

to

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668,620950
R=dpranke@chromium.org

Originally Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Reverted: https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf
==========

[Robert Sesek, 2016-06-17 23:11:26]

https://codereview.chromium.org/2072713005/diff/20001/build/toolchain/mac/cop...
File build/toolchain/mac/copy_bundle_data.py (right):

https://codereview.chromium.org/2072713005/diff/20001/build/toolchain/mac/cop...
build/toolchain/mac/copy_bundle_data.py:104: subprocess.check_call(
On 2016/06/17 17:17:28, sdefresne wrote:
> I'm not sure this is correct, see my (long) comment on
> https://codereview.chromium.org/2076853003/.

It was not correct. I mixed up how the destination was specified and so did the
inverse of the right thing in response to Dirk's comment on the original review
(https://codereview.chromium.org/2075463002/).

I added documentation to the top of the file to make it more clear in the
future.

[Dirk Pranke, 2016-06-18 01:09:24]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-06-18 01:09:24]

lgtm

[commit-bot: I haz the power, 2016-06-18 01:09:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072713005/60001

[Dirk Pranke, 2016-06-18 01:09:44]

cq'ing to see what happens and so we can flip the builders over if this seems to
work.

[commit-bot: I haz the power, 2016-06-18 01:58:19]

Description was changed from

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668,620950
R=dpranke@chromium.org

Originally Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Reverted: https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf
==========

to

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668,620950
R=dpranke@chromium.org

Originally Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Reverted: https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf
==========

[commit-bot: I haz the power, 2016-06-18 01:58:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-18 02:00:02]

Description was changed from

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668,620950
R=dpranke@chromium.org

Originally Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Reverted: https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf
==========

to

==========
[Mac/iOS/GN] Use rsync in copy_bundle_data instead of shutil.copytree.

As the TODO this fixes states, copytree preserves mtimes. This can cause
overbuild when building bundled products. Switch to using rsync to have more
control over copy parameters.

BUG=297668,620950
R=dpranke@chromium.org

Originally Committed: https://crrev.com/0cc137a639e9eb687b0fbde47983d672bcc8ef9f
Reverted: https://crrev.com/e127bb46966c5d7eec116a9612502e1cd0ea20cf

Committed: https://crrev.com/e10a42e0d13e56e035a290b66a873442a7f71cf7
Cr-Commit-Position: refs/heads/master@{#400570}
==========

[commit-bot: I haz the power, 2016-06-18 02:00:03]

Patchset 4 (id:??) landed as
https://crrev.com/e10a42e0d13e56e035a290b66a873442a7f71cf7
Cr-Commit-Position: refs/heads/master@{#400570}

[Dan Beam, 2016-07-13 01:20:43]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-07-13 01:20:44]

https://codereview.chromium.org/2072713005/diff/60001/testing/buildbot/trybot...
File testing/buildbot/trybot_analyze_config.json (right):

https://codereview.chromium.org/2072713005/diff/60001/testing/buildbot/trybot...
testing/buildbot/trybot_analyze_config.json:20: "build/toolchain/mac/*.py",
fyi: this string is fed to re.compile()[1], not glob()[2], so this will match:

  build/toolchain/mac/////.py

but not

  build/toolchain/mac/whatever.py

as you were probably expecting.

[1]
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/filter/ap...
[2] https://docs.python.org/2/library/glob.html