[telemetry] Print browser standard output and log upon BrowserTestCase failures

[telemetry] Print browser standard output and log upon BrowserTestCase failures

This patch adds a metaclass which ensures that all test* methods of all
subclasses of BrowserTestCase print browser standard output and log upon
failure.

BUG=chromium:612779
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/752a1c413f80eda020916f3715340144b9c6358c

[petrcermak, 2016-06-16 13:43:15]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com

[petrcermak, 2016-06-16 13:43:15]

PTAL.

Thanks,
Petr

[nednguyen, 2016-06-16 13:50:50]

Oh wow. lgtm

https://codereview.chromium.org/2072713003/diff/1/telemetry/telemetry/testing...
File telemetry/telemetry/testing/browser_test_case.py (right):

https://codereview.chromium.org/2072713003/diff/1/telemetry/telemetry/testing...
telemetry/telemetry/testing/browser_test_case.py:20: class
MetaBrowserTestCase(type):
nits: make this private

[petrcermak, 2016-06-16 13:58:06]

I thought I'd never get to actually use metaclasses in real life :-)

Thanks for your review.

Petr

https://codereview.chromium.org/2072713003/diff/1/telemetry/telemetry/testing...
File telemetry/telemetry/testing/browser_test_case.py (right):

https://codereview.chromium.org/2072713003/diff/1/telemetry/telemetry/testing...
telemetry/telemetry/testing/browser_test_case.py:20: class
MetaBrowserTestCase(type):
On 2016/06/16 13:50:50, nednguyen wrote:
> nits: make this private

Done.

[petrcermak, 2016-06-16 13:58:13]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-06-16 13:58:14]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2072713003/#ps20001
(title: "Make the metaclass private")

[commit-bot: I haz the power, 2016-06-16 13:58:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072713003/20001

[nednguyen, 2016-06-16 14:00:50]

On 2016/06/16 13:58:06, petrcermak wrote:
> I thought I'd never get to actually use metaclasses in real life :-)
> 
> Thanks for your review.
> 
> Petr
> 
>
https://codereview.chromium.org/2072713003/diff/1/telemetry/telemetry/testing...
> File telemetry/telemetry/testing/browser_test_case.py (right):
> 
>
https://codereview.chromium.org/2072713003/diff/1/telemetry/telemetry/testing...
> telemetry/telemetry/testing/browser_test_case.py:20: class
> MetaBrowserTestCase(type):
> On 2016/06/16 13:50:50, nednguyen wrote:
> > nits: make this private
> 
> Done.

Yeah, as long as the logic is "macro" like, metaclass is ok to use. But like
macro, it can sometimes bite :P

[commit-bot: I haz the power, 2016-06-16 14:20:53]

Description was changed from

==========
[telemetry] Print browser standard output and log upon BrowserTestCase failures

This patch adds a metaclass which ensures that all test* methods of all
subclasses of BrowserTestCase print browser standard output and log upon
failure.

BUG=chromium:612779
==========

to

==========
[telemetry] Print browser standard output and log upon BrowserTestCase failures

This patch adds a metaclass which ensures that all test* methods of all
subclasses of BrowserTestCase print browser standard output and log upon
failure.

BUG=chromium:612779

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-06-16 14:20:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...