WTF: Simplify RefPtr::operator bool.

WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

BUG=607208
Committed: https://crrev.com/2b6875bfd954d336432702512d1ffe4c83343d2b
Cr-Commit-Position: refs/heads/master@{#400315}

[jbroman, 2016-06-16 21:17:07]

jbroman@chromium.org changed reviewers:
+ thakis@chromium.org

[jbroman, 2016-06-16 21:17:07]

Apologies for being wrong before; I _thought_ I'd uploaded the "return m_ptr"
version, but apparently I'd instead uploaded the "keep the old function body,
just move to operator bool" version.

So this is the other part of that, which is simplifying the body of operator
bool to the obvious one. A few perf trybots don't suggest any noticeable
regression (at least, nothing visible in the considerable noise I see on them),
and the memchr change does seem to have fixed it.

[Nico, 2016-06-16 22:41:24]

Lgtm

I _almost_ asked if that was what you wanted...

[Nico, 2016-06-16 22:41:41]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-06-16 22:42:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072703002/1

[commit-bot: I haz the power, 2016-06-17 00:36:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-17 00:38:19]

Description was changed from

==========
WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

BUG=607208
==========

to

==========
WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

BUG=607208

Committed: https://crrev.com/2b6875bfd954d336432702512d1ffe4c83343d2b
Cr-Commit-Position: refs/heads/master@{#400315}
==========

[commit-bot: I haz the power, 2016-06-17 00:38:20]

Patchset 1 (id:??) landed as
https://crrev.com/2b6875bfd954d336432702512d1ffe4c83343d2b
Cr-Commit-Position: refs/heads/master@{#400315}

[DaleCurtis, 2016-06-17 01:16:34]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-06-17 01:16:34]

I think this broke the x64 build:

FAILED:
obj/content/renderer/content_renderer.notification_permission_dispatcher.obj 
ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc
"C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe"
/nologo /showIncludes /FC
@obj\content\renderer\content_renderer.notification_permission_dispatcher.obj.rsp
/c ..\..\content\renderer\notification_permission_dispatcher.cc
/Foobj\content\renderer\content_renderer.notification_permission_dispatcher.obj
/Fdobj\content\content_renderer.cc.pdb 
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\refptr.h(73):
error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\refptr.h(73):
note: while compiling class template member function
'WTF::RefPtr<WTF::StringImpl>::operator bool(void) const'
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\text\wtfstring.h(179):
note: see reference to function template instantiation
'WTF::RefPtr<WTF::StringImpl>::operator bool(void) const' being compiled
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\text\wtfstring.h(428):
note: see reference to class template instantiation
'WTF::RefPtr<WTF::StringImpl>' being compiled
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\refptr.h(73):
warning C4800: 'WTF::StringImpl *const ': forcing value to bool 'true' or
'false' (performance warning)
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\refptr.h(73):
warning C4800: 'WTF::CStringBuffer *const ': forcing value to bool 'true' or
'false' (performance warning)
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\refptr.h(73):
note: while compiling class template member function
'WTF::RefPtr<WTF::CStringBuffer>::operator bool(void) const'
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\text\cstring.h(71):
note: see reference to function template instantiation
'WTF::RefPtr<WTF::CStringBuffer>::operator bool(void) const' being compiled
c:\b\build\slave\win_x64\build\src\third_party\webkit\source\wtf\text\cstring.h(87):
note: see reference to class template instantiation
'WTF::RefPtr<WTF::CStringBuffer>' being compiled
[20435/32742] LIB obj\third_party\WebKit\Source\web\blink_web.lib

[DaleCurtis, 2016-06-17 01:19:34]

No response via chat, so reverting.

[DaleCurtis, 2016-06-17 01:19:56]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2071183002/ by dalecurtis@chromium.org.

The reason for reverting is: Broke x64 build, see original patch for details..