MSE: Use seek helper in frame_processor_unittests

MSE: Use seek helper in frame_processor_unittests

Adds and uses a simplifying seek helper test method.
Also removes TODOs around the WontFixed bug 371493.

TEST=*FrameProcessorTest.*
BUG=371493
Committed: https://crrev.com/ca1543531eec489d6878e65e412bd405b444696c
Cr-Commit-Position: refs/heads/master@{#400493}

[wolenetz, 2016-06-16 03:27:14]

wolenetz@chromium.org changed reviewers:
+ chcunningham@chromium.org

[wolenetz, 2016-06-16 03:27:16]

Please take a look. This is the test helper CL I mentioned in
https://codereview.chromium.org/2035003002/diff/80001/media/filters/frame_pro....

(This depends on first landing https://codereview.chromium.org/2035003002/)

[chcunningham, 2016-06-16 18:24:56]

lgtm

https://codereview.chromium.org/2072673002/diff/1/media/filters/frame_process...
File media/filters/frame_processor_unittest.cc (right):

https://codereview.chromium.org/2072673002/diff/1/media/filters/frame_process...
media/filters/frame_processor_unittest.cc:666: // http://crbug.com/371493.
So you would have SBS just return its earliest buffers absent a seek? I think
the Seek is probably pretty baked into the way the pipeline works at this point,
so this may not be a big deal

[wolenetz, 2016-06-16 19:08:53]

Description was changed from

==========
MSE: Use seek helper in frame_processor_unittests

Adds and uses a simplifying seek helper test method.

TEST=*FrameProcessorTest.*
==========

to

==========
MSE: Use seek helper in frame_processor_unittests

Adds and uses a simplifying seek helper test method.
Also removes TODOs around the WontFixed bug 371493.

TEST=*FrameProcessorTest.*
BUG=371493
==========

[wolenetz, 2016-06-16 19:15:36]

Thanks for review. I'll CQ this once https://codereview.chromium.org/2035003002/
lands.

https://codereview.chromium.org/2072673002/diff/1/media/filters/frame_process...
File media/filters/frame_processor_unittest.cc (right):

https://codereview.chromium.org/2072673002/diff/1/media/filters/frame_process...
media/filters/frame_processor_unittest.cc:666: // http://crbug.com/371493.
On 2016/06/16 18:24:56, chcunningham wrote:
> So you would have SBS just return its earliest buffers absent a seek? I think
> the Seek is probably pretty baked into the way the pipeline works at this
point,
> so this may not be a big deal

Yeah, the bug hasn't been followed up on since it isn't a big deal. The problem
is that we could append at time 500ms, then at time 0ms. Both are within
kSeekToStartFudgeRoom, but since we satisfied the pending seek to start with the
append to 500ms first, then re-seek to start is necessary to get the data
appended at time 0ms. It's only really an issue here in these tests, since we're
constantly doing various small segement appends within that fudge room.

I'm not sure there's a good solution to the bug, given the app can always
trigger this behavior after the very first buffer at 500ms (in my example) was
read and perhaps rendered.

So, on third thought :), I'll go comment in the bug and close it; and adjust the
related comments in this CL to indicate *why* we're re-seeking, and that it's
not a bug...)

[wolenetz, 2016-06-16 20:41:53]

The CQ bit was checked by wolenetz@chromium.org

[wolenetz, 2016-06-16 20:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
chcunningham@chromium.org
Link to the patchset: https://codereview.chromium.org/2072673002/#ps20001
(title: "Rebased and addressed comment (WontFixed crbug 371493)")

[commit-bot: I haz the power, 2016-06-16 20:42:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072673002/20001

[commit-bot: I haz the power, 2016-06-17 00:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 00:22:30]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[wolenetz, 2016-06-17 17:32:12]

The CQ bit was checked by wolenetz@chromium.org

[commit-bot: I haz the power, 2016-06-17 17:32:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072673002/20001

[commit-bot: I haz the power, 2016-06-17 20:37:45]

Description was changed from

==========
MSE: Use seek helper in frame_processor_unittests

Adds and uses a simplifying seek helper test method.
Also removes TODOs around the WontFixed bug 371493.

TEST=*FrameProcessorTest.*
BUG=371493
==========

to

==========
MSE: Use seek helper in frame_processor_unittests

Adds and uses a simplifying seek helper test method.
Also removes TODOs around the WontFixed bug 371493.

TEST=*FrameProcessorTest.*
BUG=371493
==========

[commit-bot: I haz the power, 2016-06-17 20:37:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 20:39:06]

Description was changed from

==========
MSE: Use seek helper in frame_processor_unittests

Adds and uses a simplifying seek helper test method.
Also removes TODOs around the WontFixed bug 371493.

TEST=*FrameProcessorTest.*
BUG=371493
==========

to

==========
MSE: Use seek helper in frame_processor_unittests

Adds and uses a simplifying seek helper test method.
Also removes TODOs around the WontFixed bug 371493.

TEST=*FrameProcessorTest.*
BUG=371493

Committed: https://crrev.com/ca1543531eec489d6878e65e412bd405b444696c
Cr-Commit-Position: refs/heads/master@{#400493}
==========

[commit-bot: I haz the power, 2016-06-17 20:39:08]

Patchset 2 (id:??) landed as
https://crrev.com/ca1543531eec489d6878e65e412bd405b444696c
Cr-Commit-Position: refs/heads/master@{#400493}