Convert GetSearchProviderInstallState to Mojo

chrome/common/search_provider.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-module url.mojom;
+module mojom;

[sky, 2016/06/20 15:20:26]

Are we really going with a module of 'mojom' for these files? I would expect a
prefix, perhaps 'chrome.mojom'.

[tibell, 2016/06/21 01:31:32]

Done.

The other chrome/ mojom files (except one I think) do use the plain mojom
namespace and the C++ code uses no namespace. Better start late than never to
improve things I guess, even if it gets a bit inconsistent for a while. :)

 
-import "url/mojo/origin.mojom";
 import "url/mojo/url.mojom";
 
-interface UrlTest {
+[Native]
+enum InstallState;
+
+interface SearchProviderInstallState {
+  // Find out if the given url's security origin is installed as a search
+  // provider.
   [Sync]
-  BounceUrl(Url in) => (Url out);
-
-  [Sync]
-  BounceOrigin(Origin in) => (Origin out);
+  GetInstallState(
+      url.mojom.Url page_url,

[sky, 2016/06/20 15:20:26]

Document what page_url and inquiry_url are.

[tibell, 2016/06/21 01:31:32]

I've just spent some time figuring it out (it's not documented from what I can
tell) by reading the test
(https://cs.chromium.org/chromium/src/chrome/browser/external_extension_browse...)
and the implementation. I'm still not 100% sure exactly what the arguments mean.
I believe the second one is the search provider host (e.g. www.google.com) and
the first is the requesting page, but since I'm not sure and this seems security
related I'd rather not guess.

I've CC:ed levin@ for a clarification.

[levin, 2016/06/21 01:48:44]

You're basically correct except that the second is a url (not just a host --
you'd need at least a security origin (aka scheme plus host plus port) to be
secure), and it's checked over here:
https://cs.chromium.org/chromium/src/chrome/browser/search_engines/search_pro...


You can see where this is called:

https://cs.chromium.org/chromium/src/chrome/renderer/external_extension.cc?rc...

Hope that helps.

+      url.mojom.Url inquiry_url) => (
+      InstallState install);

[sky, 2016/06/20 15:20:26]

nit: this wrapping is a bit awkward. Maybe move 'InstallState install' onto the
previous line.

[tibell, 2016/06/21 01:31:32]

Done.

 };