Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 20726002: Fix for V8 issue 2795: Check fails with deopt for mjsunit/array-store-and-grow (Closed)

Created:
7 years, 5 months ago by mvstanton
Modified:
7 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix for V8 issue 2795: Check fails with deopt for mjsunit/array-store-and-grow (https://code.google.com/p/v8/issues/detail?id=2795) The reason is when allocating and building arrays in hydrogen we need to ensure we do any int32-to-smi conversions BEFORE the allocation. These conversions can at least theoretically deoptimize. If this happens before all the fields of the newly allocated object are filled in, we will have a corrupted heap. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15929

Patch Set 1 #

Patch Set 2 : Added test #

Patch Set 3 : Test cleanup #

Patch Set 4 : Removed overkillin' wrapper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -10 lines) Patch
M src/hydrogen.cc View 1 2 3 5 chunks +20 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M test/mjsunit/array-store-and-grow.js View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Toon, here is the issue we worked on, thanks! --Michael
7 years, 5 months ago (2013-07-26 12:32:57 UTC) #1
Toon Verwaest
Can you add a regression test for the MaxGrow check, that overflows the smi range?
7 years, 5 months ago (2013-07-26 13:39:13 UTC) #2
mvstanton
Done, thanks!
7 years, 4 months ago (2013-07-29 07:30:38 UTC) #3
Toon Verwaest
lgtm
7 years, 4 months ago (2013-07-29 11:49:05 UTC) #4
mvstanton
7 years, 4 months ago (2013-07-29 11:50:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r15929 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698