Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2072563002: Revert of Enable viewer in non-Vulkan builds (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Enable viewer in non-Vulkan builds (patchset #2 id:20001 of https://codereview.chromium.org/2067023002/ ) Reason for revert: breaking compile bots Original issue's description: > Enable viewer in non-Vulkan builds > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067023002 > > Committed: https://skia.googlesource.com/skia/+/746b792a9aad1230ab69158a51c49b2e5437d95b TBR=djsollen@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/963632f686cd642344429f64e6a53262fe592828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -27 lines) Patch
M gyp/most.gyp View 2 chunks +3 lines, -2 lines 0 comments Download
M gyp/viewer.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/viewer/Viewer.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M tools/viewer/sk_app/Window.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/Window.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/android/Window_android.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M tools/viewer/sk_app/unix/GLWindowContext_unix.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/viewer/sk_app/unix/Window_unix.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M tools/viewer/sk_app/win/Window_win.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
egdaniel
Created Revert of Enable viewer in non-Vulkan builds
4 years, 6 months ago (2016-06-15 21:23:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072563002/1
4 years, 6 months ago (2016-06-15 21:23:36 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 21:23:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/963632f686cd642344429f64e6a53262fe592828

Powered by Google App Engine
This is Rietveld 408576698