Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2072553002: [ios] Fixed dialogs suppression. (Closed)

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 6 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews, Andy Caruso
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed dialogs suppression. The issue happened in the following scenario: - uer typed in the omnibox to trigger preload - preload Tab set shouldSuppressDialogs to YES - web view did not exist so suppression was postponed until the load - user tapped Go to promote preload Tab to real Tab - preload Tab set shouldSuppressDialogs to NO - page loaded and postponed suppression suppresses the dialods This change always cancels postoned suppression if shouldSuppressDialogs was set to NO. BUG=618831 Committed: https://crrev.com/fc51dd2482615bab3c156bcd5d3744d146be84ee Cr-Commit-Position: refs/heads/master@{#400020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Eugene But (OOO till 7-30)
4 years, 6 months ago (2016-06-15 20:36:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072553002/1
4 years, 6 months ago (2016-06-15 20:36:52 UTC) #4
Jackie Quinn
lgtm
4 years, 6 months ago (2016-06-15 20:38:25 UTC) #5
Eugene But (OOO till 7-30)
Thank you for quick review!
4 years, 6 months ago (2016-06-15 20:40:31 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 21:23:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072553002/1
4 years, 6 months ago (2016-06-15 21:45:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 21:50:08 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 21:52:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc51dd2482615bab3c156bcd5d3744d146be84ee
Cr-Commit-Position: refs/heads/master@{#400020}

Powered by Google App Engine
This is Rietveld 408576698