Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2072543002: First cut at _spawnUri rpc in the vm service. (Closed)

Created:
4 years, 6 months ago by turnidge
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : spawn uri works #

Patch Set 3 : First cut at _spawnUri rpc in the vm service. #

Patch Set 4 : cleanup pre code review #

Total comments: 2

Patch Set 5 : Code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -1 line) Patch
M runtime/lib/vmservice.cc View 1 2 3 2 chunks +36 lines, -0 lines 0 comments Download
M runtime/lib/vmservice_patch.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/dev_fs_spawn_test.dart View 1 2 1 chunk +221 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service_event.h View 1 3 chunks +21 lines, -0 lines 0 comments Download
M runtime/vm/service_event.cc View 1 4 chunks +15 lines, -0 lines 0 comments Download
M sdk/lib/vmservice/message.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/vmservice/vmservice.dart View 1 2 3 4 3 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
turnidge
4 years, 5 months ago (2016-07-06 20:16:06 UTC) #3
Cutch
LGTM with a small nit and I'd love to see a test where we reload ...
4 years, 5 months ago (2016-07-07 16:17:45 UTC) #4
turnidge
https://codereview.chromium.org/2072543002/diff/60001/sdk/lib/vmservice/vmservice.dart File sdk/lib/vmservice/vmservice.dart (right): https://codereview.chromium.org/2072543002/diff/60001/sdk/lib/vmservice/vmservice.dart#newcode301 sdk/lib/vmservice/vmservice.dart:301: return encodeMissingParamError(message, 'token'); On 2016/07/07 16:17:45, Cutch wrote: > ...
4 years, 5 months ago (2016-07-11 21:24:59 UTC) #5
turnidge
4 years, 5 months ago (2016-07-11 21:25:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
3a51fceaba080a6d08299d33dcacc881127838d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698