Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2072453002: Add heap tests for Vulkan (Closed)

Created:
4 years, 6 months ago by jvanverth1
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add heap tests for Vulkan. Also fixes some bugs that were found. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2072453002 Committed: https://skia.googlesource.com/skia/+/d6f8034b886d59a3c722bf3932195143f2bf5eb8

Patch Set 1 #

Patch Set 2 : Add more tests; fix bugs #

Patch Set 3 : One last test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -4 lines) Patch
M src/gpu/vk/GrVkMemory.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkMemory.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
A tests/VkHeapTests.cpp View 1 2 1 chunk +208 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jvanverth1
4 years, 6 months ago (2016-06-15 20:29:34 UTC) #4
bsalomon
lgtm
4 years, 6 months ago (2016-06-15 21:04:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072453002/40001
4 years, 6 months ago (2016-06-16 11:28:37 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 11:42:34 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d6f8034b886d59a3c722bf3932195143f2bf5eb8

Powered by Google App Engine
This is Rietveld 408576698